From: David Miller <davem@davemloft.net>
To: alex.bluesman.smirnov@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] rtnetlink: rtnl_link_register always returns zero
Date: Tue, 13 Dec 2011 16:08:10 -0500 (EST) [thread overview]
Message-ID: <20111213.160810.785264274549847462.davem@davemloft.net> (raw)
In-Reply-To: <1323808281-9967-1-git-send-email-alex.bluesman.smirnov@gmail.com>
From: alex.bluesman.smirnov@gmail.com
Date: Wed, 14 Dec 2011 00:31:21 +0400
> From: Alexander Smirnov <alexander@Lenovo.(none)>
>
> Both functions 'rtnl_link_register' and '__rtnl_link_register' always
> return zero. So handling return status has no sense in several drivers.
>
> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
This is never acceptable.
As long as those routines do return a value we SHOULD NOT ignore
it.
If you ignore it, then if we do have to start returning an error
then all of these call sites have to be reverted back, which is
a waste of time.
next prev parent reply other threads:[~2011-12-13 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 20:31 [PATCH] rtnetlink: rtnl_link_register always returns zero alex.bluesman.smirnov
2011-12-13 21:08 ` David Miller [this message]
2011-12-13 21:38 ` [PATCH net-next] rtnetlink: rtnl_link_register() sanity test Eric Dumazet
2011-12-14 7:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213.160810.785264274549847462.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).