From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] bridge: push blocking slaves to forwarding when turning stp off Date: Tue, 13 Dec 2011 16:16:13 -0800 Message-ID: <20111213161613.0c59ab36@nehalam.linuxnetplumber.net> References: <201112131136.25919.vitas@nppfactor.kiev.ua> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org To: Vitalii Demianets Return-path: In-Reply-To: <201112131136.25919.vitas@nppfactor.kiev.ua> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Tue, 13 Dec 2011 11:36:25 +0200 Vitalii Demianets wrote: > If there is a slave in blocking state when stp is turned off, that slave will > remain in blocking state for indefinitely long time until interface state > changed. We should push all blocking slaves into forwarding state after > turning stp off. > > Signed-off-by: Vitalii Demianets Maybe. But if the port was in the blocking state then STP must have decided there was a loop in the network if that port was used. Therefore blindly putting the port into forwarding state could cause disastrous network flood. The user can force the port back out of blocking state (via sysfs).