From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: kaber@trash.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, jpirko@redhat.com
Subject: Re: [patch] vlan: add rtnl_dereference() annotations
Date: Wed, 14 Dec 2011 02:47:19 -0500 (EST) [thread overview]
Message-ID: <20111214.024719.723458248077070552.davem@davemloft.net> (raw)
In-Reply-To: <20111214062943.GD7499@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 14 Dec 2011 09:29:43 +0300
> The original code generates a Sparse warning:
> net/8021q/vlan_core.c:336:9:
> error: incompatible types in comparison expression (different address spaces)
>
> It's ok to dereference __rcu pointers here because we are holding the
> RTNL lock. I've added some calls to rtnl_dereference() to silence the
> warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
prev parent reply other threads:[~2011-12-14 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 6:29 [patch] vlan: add rtnl_dereference() annotations Dan Carpenter
2011-12-14 7:01 ` Eric Dumazet
2011-12-14 7:34 ` Jiri Pirko
2011-12-14 7:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214.024719.723458248077070552.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).