From mboxrd@z Thu Jan 1 00:00:00 1970 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls Date: Thu, 15 Dec 2011 14:40:19 +0900 Message-ID: <20111215144019.03706ff7.kamezawa.hiroyu@jp.fujitsu.com> References: <1323676029-5890-1-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, ebiederm@xmission.com, gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, kirill@shutemov.name, avagin@parallels.com, devel@openvz.org, eric.dumazet@gmail.com, cgroups@vger.kernel.org To: Glauber Costa Return-path: In-Reply-To: <1323676029-5890-1-git-send-email-glommer@parallels.com> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org On Mon, 12 Dec 2011 11:47:00 +0400 Glauber Costa wrote: > Hi, > > This series fixes all the few comments raised in the last round, > and seem to have acquired consensus from the memcg side. > > Dave, do you think it is acceptable now from the networking PoV? > In case positive, would you prefer merging this trough your tree, > or acking this so a cgroup maintainer can do it? > I met this bug at _1st_ run. Please enable _all_ debug options!. >>From this log, your mem_cgroup_sockets_init() is totally buggy because tcp init routine will call percpu_alloc() under read_lock. please fix. I'll turn off the config for today's linux-next. Regards, -Kame == Dec 15 14:47:15 bluextal kernel: [ 228.386054] BUG: sleeping function called from invalid context at k ernel/mutex.c:271 Dec 15 14:47:15 bluextal kernel: [ 228.386286] in_atomic(): 1, irqs_disabled(): 0, pid: 2692, name: cg create Dec 15 14:47:15 bluextal kernel: [ 228.386438] 4 locks held by cgcreate/2692: Dec 15 14:47:15 bluextal kernel: [ 228.386580] #0: (&sb->s_type->i_mutex_key#15/1){+.+.+.}, at: [] kern_path_create+0x8e/0x150 Dec 15 14:47:15 bluextal kernel: [ 228.387238] #1: (cgroup_mutex){+.+.+.}, at: [] cgroup_mkdir+0x77/0x3f0 Dec 15 14:47:15 bluextal kernel: [ 228.387755] #2: (&sb->s_type->i_mutex_key#15/2){+.+.+.}, at: [] cgroup_create_file+0xc8/0xf0 Dec 15 14:47:15 bluextal kernel: [ 228.388401] #3: (proto_list_lock){++++.+}, at: [] mem_cgroup_sockets_init+0x24/0xf0 Dec 15 14:47:15 bluextal kernel: [ 228.388922] Pid: 2692, comm: cgcreate Not tainted 3.2.0-rc5-next-20 111214+ #34 Dec 15 14:47:15 bluextal kernel: [ 228.389154] Call Trace: Dec 15 14:47:15 bluextal kernel: [ 228.389296] [] __might_sleep+0x107/0x140 Dec 15 14:47:15 bluextal kernel: [ 228.389446] [] mutex_lock_nested+0x2f/0x50 Dec 15 14:47:15 bluextal kernel: [ 228.389597] [] pcpu_alloc+0x4d/0xa20 Dec 15 14:47:15 bluextal kernel: [ 228.389745] [] ? debug_check_no_locks_freed+0xa9/0x180 Dec 15 14:47:15 bluextal kernel: [ 228.389897] [] ? trace_hardirqs_on_caller+0x105/0x190 Dec 15 14:47:15 bluextal kernel: [ 228.390057] [] ? trace_hardirqs_on+0xd/0x10 Dec 15 14:47:15 bluextal kernel: [ 228.390206] [] ? lockdep_init_map+0x50/0x140 Dec 15 14:47:15 bluextal kernel: [ 228.390356] [] __alloc_percpu+0x10/0x20 Dec 15 14:47:15 bluextal kernel: [ 228.390506] [] __percpu_counter_init+0x58/0xc0 Dec 15 14:47:15 bluextal kernel: [ 228.390658] [] tcp_init_cgroup+0xd6/0x140 Dec 15 14:47:15 bluextal kernel: [ 228.390808] [] mem_cgroup_sockets_init+0x54/0xf0 Dec 15 14:47:15 bluextal kernel: [ 228.390961] [] mem_cgroup_populate+0xab/0xc0 Dec 15 14:47:15 bluextal kernel: [ 228.391120] [] cgroup_populate_dir+0x7a/0x110 Dec 15 14:47:15 bluextal kernel: [ 228.391271] [] cgroup_mkdir+0x286/0x3f0 Dec 15 14:47:15 bluextal kernel: [ 228.391420] [] vfs_mkdir+0xa4/0xe0 Dec 15 14:47:15 bluextal kernel: [ 228.391566] [] sys_mkdirat+0xcd/0xe0 Dec 15 14:47:15 bluextal kernel: [ 228.391714] [] sys_mkdir+0x18/0x20 Dec 15 14:47:15 bluextal kernel: [ 228.391862] [] tracesys+0xdd/0xe2 == -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org