* Re: [PATCH] asix: new device id [not found] <1324050921-9007-1-git-send-email-aurel@gnuage.org> @ 2011-12-16 16:38 ` Jiri Kosina 2011-12-16 18:32 ` David Miller 0 siblings, 1 reply; 9+ messages in thread From: Jiri Kosina @ 2011-12-16 16:38 UTC (permalink / raw) To: Aurelien Jacobs; +Cc: linux-kernel, netdev On Fri, 16 Dec 2011, Aurelien Jacobs wrote: > Adds the device id needed for the USB Ethernet Adapter delivered by > ASUS with their Zenbook. > > Signed-off-by: Aurelien Jacobs <aurel@gnuage.org> > --- > drivers/net/usb/asix.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c > index e6fed4d..e95f0e6 100644 > --- a/drivers/net/usb/asix.c > +++ b/drivers/net/usb/asix.c > @@ -1655,6 +1655,10 @@ static const struct usb_device_id products [] = { > // ASIX 88772a > USB_DEVICE(0x0db0, 0xa877), > .driver_info = (unsigned long) &ax88772_info, > +}, { > + // Asus USB Ethernet Adapter > + USB_DEVICE (0x0b95, 0x7e2b), > + .driver_info = (unsigned long) &ax88772_info, > }, > { }, // END > }; Adding netdev to CC so that it doesn't get lost. -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] asix: new device id 2011-12-16 16:38 ` [PATCH] asix: new device id Jiri Kosina @ 2011-12-16 18:32 ` David Miller 2011-12-16 20:49 ` Aurelien Jacobs 0 siblings, 1 reply; 9+ messages in thread From: David Miller @ 2011-12-16 18:32 UTC (permalink / raw) To: jkosina; +Cc: aurel, linux-kernel, netdev From: Jiri Kosina <jkosina@suse.cz> Date: Fri, 16 Dec 2011 17:38:13 +0100 (CET) > On Fri, 16 Dec 2011, Aurelien Jacobs wrote: > >> Adds the device id needed for the USB Ethernet Adapter delivered by >> ASUS with their Zenbook. >> >> Signed-off-by: Aurelien Jacobs <aurel@gnuage.org> >> --- >> drivers/net/usb/asix.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c >> index e6fed4d..e95f0e6 100644 >> --- a/drivers/net/usb/asix.c >> +++ b/drivers/net/usb/asix.c >> @@ -1655,6 +1655,10 @@ static const struct usb_device_id products [] = { >> // ASIX 88772a >> USB_DEVICE(0x0db0, 0xa877), >> .driver_info = (unsigned long) &ax88772_info, >> +}, { >> + // Asus USB Ethernet Adapter >> + USB_DEVICE (0x0b95, 0x7e2b), >> + .driver_info = (unsigned long) &ax88772_info, >> }, >> { }, // END >> }; > > Adding netdev to CC so that it doesn't get lost. Only submitting the actual patch, unquoted, to netdev makes sure it gets queued up in patchwork, and therefore not lost. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] asix: new device id 2011-12-16 18:32 ` David Miller @ 2011-12-16 20:49 ` Aurelien Jacobs 2011-12-19 21:00 ` David Miller 0 siblings, 1 reply; 9+ messages in thread From: Aurelien Jacobs @ 2011-12-16 20:49 UTC (permalink / raw) To: netdev; +Cc: Aurelien Jacobs Adds the device id needed for the USB Ethernet Adapter delivered by ASUS with their Zenbook. Signed-off-by: Aurelien Jacobs <aurel@gnuage.org> --- drivers/net/usb/asix.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c index e6fed4d..e95f0e6 100644 --- a/drivers/net/usb/asix.c +++ b/drivers/net/usb/asix.c @@ -1655,6 +1655,10 @@ static const struct usb_device_id products [] = { // ASIX 88772a USB_DEVICE(0x0db0, 0xa877), .driver_info = (unsigned long) &ax88772_info, +}, { + // Asus USB Ethernet Adapter + USB_DEVICE (0x0b95, 0x7e2b), + .driver_info = (unsigned long) &ax88772_info, }, { }, // END }; -- 1.7.7.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] asix: new device id 2011-12-16 20:49 ` Aurelien Jacobs @ 2011-12-19 21:00 ` David Miller 2011-12-19 21:22 ` Grant Grundler 0 siblings, 1 reply; 9+ messages in thread From: David Miller @ 2011-12-19 21:00 UTC (permalink / raw) To: aurel; +Cc: netdev, grundler From: Aurelien Jacobs <aurel@gnuage.org> Date: Fri, 16 Dec 2011 21:49:22 +0100 > Adds the device id needed for the USB Ethernet Adapter delivered by > ASUS with their Zenbook. > > Signed-off-by: Aurelien Jacobs <aurel@gnuage.org> Grant, ACK/NACK? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] asix: new device id 2011-12-19 21:00 ` David Miller @ 2011-12-19 21:22 ` Grant Grundler 2011-12-19 21:25 ` David Miller 2011-12-20 0:41 ` allan 0 siblings, 2 replies; 9+ messages in thread From: Grant Grundler @ 2011-12-19 21:22 UTC (permalink / raw) To: David Miller; +Cc: aurel, netdev, Allan Chou, Freddy Xin On Mon, Dec 19, 2011 at 1:00 PM, David Miller <davem@davemloft.net> wrote: > From: Aurelien Jacobs <aurel@gnuage.org> > Date: Fri, 16 Dec 2011 21:49:22 +0100 > >> Adds the device id needed for the USB Ethernet Adapter delivered by >> ASUS with their Zenbook. >> >> Signed-off-by: Aurelien Jacobs <aurel@gnuage.org> > > Grant, ACK/NACK? Dave, I'm totally ok with it if Aurelien is confident it "works" (well enough). I'm really the wrong guy to ask though. I don't have the device and I'm not associated with the mfg. The right people to ask (CC'd) are Allan Chou and Freddy Xin (both from ASIX). cheers! grant ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] asix: new device id 2011-12-19 21:22 ` Grant Grundler @ 2011-12-19 21:25 ` David Miller 2011-12-19 21:34 ` Grant Grundler 2011-12-20 0:41 ` allan 1 sibling, 1 reply; 9+ messages in thread From: David Miller @ 2011-12-19 21:25 UTC (permalink / raw) To: grundler; +Cc: aurel, netdev, allan, freddy From: Grant Grundler <grundler@google.com> Date: Mon, 19 Dec 2011 13:22:35 -0800 > I'm really the wrong guy to ask though. I don't have the device > and I'm not associated with the mfg. Strongly disagree. When you make changes to a driver, in fact you've made the most recent 5 or 6, it's like "tag, you're it" :-) Just so you understand why I am not going to ask random people who have never submitted a change to the driver whether a change makes sense or not. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] asix: new device id 2011-12-19 21:25 ` David Miller @ 2011-12-19 21:34 ` Grant Grundler 2011-12-19 21:38 ` David Miller 0 siblings, 1 reply; 9+ messages in thread From: Grant Grundler @ 2011-12-19 21:34 UTC (permalink / raw) To: David Miller; +Cc: aurel, netdev, allan, freddy On Mon, Dec 19, 2011 at 1:25 PM, David Miller <davem@davemloft.net> wrote: > From: Grant Grundler <grundler@google.com> > Date: Mon, 19 Dec 2011 13:22:35 -0800 > >> I'm really the wrong guy to ask though. I don't have the device >> and I'm not associated with the mfg. > > Strongly disagree. > > When you make changes to a driver, in fact you've made the most > recent 5 or 6, it's like "tag, you're it" :-) Fair enough. :) But I'm trying to change that. :) (Have ASIX to participate in asix.c devel/support). Acked-by: Grant Grundler <grundler@chromium.org> The change is "harmless" in that it won't interfere with anything that works today. > Just so you understand why I am not going to ask random people who > have never submitted a change to the driver whether a change makes > sense or not. Understood. But I have no clue what driver functionality *will* work with the new device. I guess this is the first step to finding out. :) cheers, grant ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] asix: new device id 2011-12-19 21:34 ` Grant Grundler @ 2011-12-19 21:38 ` David Miller 0 siblings, 0 replies; 9+ messages in thread From: David Miller @ 2011-12-19 21:38 UTC (permalink / raw) To: grundler; +Cc: aurel, netdev, allan, freddy From: Grant Grundler <grundler@chromium.org> Date: Mon, 19 Dec 2011 13:34:24 -0800 > On Mon, Dec 19, 2011 at 1:25 PM, David Miller <davem@davemloft.net> wrote: >> From: Grant Grundler <grundler@google.com> >> Date: Mon, 19 Dec 2011 13:22:35 -0800 >> >>> I'm really the wrong guy to ask though. I don't have the device >>> and I'm not associated with the mfg. >> >> Strongly disagree. >> >> When you make changes to a driver, in fact you've made the most >> recent 5 or 6, it's like "tag, you're it" :-) > > Fair enough. :) But I'm trying to change that. :) (Have ASIX to > participate in asix.c devel/support). > > > Acked-by: Grant Grundler <grundler@chromium.org> That's the spirit :-) Aplied, thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] asix: new device id 2011-12-19 21:22 ` Grant Grundler 2011-12-19 21:25 ` David Miller @ 2011-12-20 0:41 ` allan 1 sibling, 0 replies; 9+ messages in thread From: allan @ 2011-12-20 0:41 UTC (permalink / raw) To: 'Grant Grundler', 'David Miller' Cc: aurel, netdev, 'Freddy Xin', ASIX Louis [蘇威陸] Dear David, ASUS's USB to Ethernet adapter (delivered with Zenbook) implemented ASIX's latest USB 2.0 to Fast Ethernet solution, AX88772B inside. ASUS hopes to enable the WOL function on Windows system by default so we assigned a new VID/PID (0B95h/7E2Bh) to meet their requirement. For Linux native driver, you can easily add the new VID/PID (0B95h/7E2Bh) to work as the AX88772B (with default VID/PID, 0B95h/772Bh). Please feel free to let us know if you have any problems or need more information. Thanks a lot for your great helps. --- Best regards, Allan Chou Technical Support Division ASIX Electronics Corporation TEL: 886-3-5799500 ext.228 FAX: 886-3-5799558 E-mail: allan@asix.com.tw http://www.asix.com.tw/ -----Original Message----- From: Grant Grundler [mailto:grundler@google.com] Sent: Tuesday, December 20, 2011 5:23 AM To: David Miller Cc: aurel@gnuage.org; netdev@vger.kernel.org; Allan Chou; Freddy Xin Subject: Re: [PATCH] asix: new device id On Mon, Dec 19, 2011 at 1:00 PM, David Miller <davem@davemloft.net> wrote: > From: Aurelien Jacobs <aurel@gnuage.org> > Date: Fri, 16 Dec 2011 21:49:22 +0100 > >> Adds the device id needed for the USB Ethernet Adapter delivered by >> ASUS with their Zenbook. >> >> Signed-off-by: Aurelien Jacobs <aurel@gnuage.org> > > Grant, ACK/NACK? Dave, I'm totally ok with it if Aurelien is confident it "works" (well enough). I'm really the wrong guy to ask though. I don't have the device and I'm not associated with the mfg. The right people to ask (CC'd) are Allan Chou and Freddy Xin (both from ASIX). cheers! grant ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-12-20 0:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1324050921-9007-1-git-send-email-aurel@gnuage.org>
2011-12-16 16:38 ` [PATCH] asix: new device id Jiri Kosina
2011-12-16 18:32 ` David Miller
2011-12-16 20:49 ` Aurelien Jacobs
2011-12-19 21:00 ` David Miller
2011-12-19 21:22 ` Grant Grundler
2011-12-19 21:25 ` David Miller
2011-12-19 21:34 ` Grant Grundler
2011-12-19 21:38 ` David Miller
2011-12-20 0:41 ` allan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).