From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] sch_gred: prefer GFP_KERNEL allocations
Date: Fri, 16 Dec 2011 15:41:17 -0500 (EST) [thread overview]
Message-ID: <20111216.154117.606081273063232714.davem@davemloft.net> (raw)
In-Reply-To: <1324022985.2562.39.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 16 Dec 2011 09:09:45 +0100
> In control path, its better to use GFP_KERNEL allocations where
> possible.
>
> Before taking qdisc spinlock, we preallocate memory just in case we'll
> need it in gred_change_vq()
>
> This is a followup to commit 3f1e6d3fd37b (sch_gred: should not use
> GFP_KERNEL while holding a spinlock)
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2011-12-16 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 8:09 [PATCH net-next] sch_gred: prefer GFP_KERNEL allocations Eric Dumazet
2011-12-16 20:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216.154117.606081273063232714.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).