From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 03/14] mac802154: RX data path
Date: Mon, 19 Dec 2011 14:36:08 -0500 (EST) [thread overview]
Message-ID: <20111219.143608.1409188332664691009.davem@davemloft.net> (raw)
In-Reply-To: <1324312434-13151-3-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Mon, 19 Dec 2011 19:33:43 +0300
> +void ieee802154_rx(struct ieee802154_dev *dev, struct sk_buff *skb, u8 lqi);
> +void ieee802154_rx_irqsafe(struct ieee802154_dev *dev, struct sk_buff *skb,
> + u8 lqi);
Line up the "u8 lqi" argument with the openning parenthesis on the previous line.
> +static void
> +mac802154_subif_rx(struct ieee802154_dev *hw, struct sk_buff *skb, u8 lqi)
> +{
> + struct mac802154_priv *priv = mac802154_to_priv(hw);
> +
> + BUG_ON(!skb);
This assertion is excessive.
You are adding all of the call sites, therefore you can see if the SKB
argument is NULL or not.
------------------------------------------------------------------------------
Learn Windows Azure Live! Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for
developers. It will provide a great way to learn Windows Azure and what it
provides. You can attend the event by watching it streamed LIVE online.
Learn more at http://p.sf.net/sfu/ms-windowsazure
next prev parent reply other threads:[~2011-12-19 19:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 16:31 [PATCH series v1] IEEE 802.15.4 MAC layer basic implementation Alexander Smirnov
2011-12-19 16:33 ` [PATCH 01/14] mac802154: basic ieee802.15.4 device structures Alexander Smirnov
2011-12-19 19:32 ` David Miller
2011-12-19 16:33 ` [PATCH 02/14] mac802154: allocation of ieee802154 device Alexander Smirnov
[not found] ` <1324312434-13151-2-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:34 ` David Miller
2011-12-19 16:33 ` [PATCH 03/14] mac802154: RX data path Alexander Smirnov
[not found] ` <1324312434-13151-3-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:36 ` David Miller [this message]
2011-12-19 16:33 ` [PATCH 04/14] mac802154: TX " Alexander Smirnov
[not found] ` <1324312434-13151-4-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:38 ` David Miller
[not found] ` <20111219163117.GA13123-AUGNqIMGY+bGcXpsla5Oef8+0UxHXcjY@public.gmane.org>
2011-12-19 16:33 ` [PATCH 05/14] mac802154: define reduced mlme operations Alexander Smirnov
2011-12-19 16:33 ` [PATCH 06/14] mac802154: slave interfaces definition Alexander Smirnov
[not found] ` <1324312434-13151-6-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:38 ` David Miller
2011-12-19 16:33 ` [PATCH 07/14] mac802154: reduced mlme operations Alexander Smirnov
2011-12-19 16:33 ` [PATCH 08/14] mac802154: basic mib support Alexander Smirnov
[not found] ` <1324312434-13151-8-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:39 ` David Miller
2011-12-19 16:33 ` [PATCH 09/14] ieee802154: remove ieee802154 policy from globals Alexander Smirnov
[not found] ` <1324312434-13151-9-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:40 ` David Miller
2011-12-19 16:33 ` [PATCH 10/14] ieee802154: interface type to be added Alexander Smirnov
[not found] ` <1324312434-13151-10-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:42 ` David Miller
2011-12-19 16:33 ` [PATCH 11/14] mac802154: slaves manipulation routine Alexander Smirnov
[not found] ` <1324312434-13151-11-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:43 ` David Miller
2011-12-20 1:08 ` Joe Perches
2011-12-19 16:33 ` [PATCH 12/14] mac802154: monitor device support Alexander Smirnov
2011-12-19 19:47 ` David Miller
2011-12-19 16:33 ` [PATCH 13/14] drivers/ieee802154: IEEE 802.15.4 loopback driver Alexander Smirnov
[not found] ` <1324312434-13151-13-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:49 ` David Miller
2011-12-19 16:33 ` [PATCH 14/14] Documentation/networking/ieee802154: update MAC chapter Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219.143608.1409188332664691009.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).