From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 03/14] mac802154: RX data path Date: Mon, 19 Dec 2011 14:36:08 -0500 (EST) Message-ID: <20111219.143608.1409188332664691009.davem@davemloft.net> References: <20111219163117.GA13123@avtobot.cybertron> <1324312434-13151-3-git-send-email-alex.bluesman.smirnov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1324312434-13151-3-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org From: Alexander Smirnov Date: Mon, 19 Dec 2011 19:33:43 +0300 > +void ieee802154_rx(struct ieee802154_dev *dev, struct sk_buff *skb, u8 lqi); > +void ieee802154_rx_irqsafe(struct ieee802154_dev *dev, struct sk_buff *skb, > + u8 lqi); Line up the "u8 lqi" argument with the openning parenthesis on the previous line. > +static void > +mac802154_subif_rx(struct ieee802154_dev *hw, struct sk_buff *skb, u8 lqi) > +{ > + struct mac802154_priv *priv = mac802154_to_priv(hw); > + > + BUG_ON(!skb); This assertion is excessive. You are adding all of the call sites, therefore you can see if the SKB argument is NULL or not. ------------------------------------------------------------------------------ Learn Windows Azure Live! Tuesday, Dec 13, 2011 Microsoft is holding a special Learn Windows Azure training event for developers. It will provide a great way to learn Windows Azure and what it provides. You can attend the event by watching it streamed LIVE online. Learn more at http://p.sf.net/sfu/ms-windowsazure