From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 04/14] mac802154: TX data path Date: Mon, 19 Dec 2011 14:38:05 -0500 (EST) Message-ID: <20111219.143805.830165510696607381.davem@davemloft.net> References: <20111219163117.GA13123@avtobot.cybertron> <1324312434-13151-4-git-send-email-alex.bluesman.smirnov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1324312434-13151-4-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org From: Alexander Smirnov Date: Mon, 19 Dec 2011 19:33:44 +0300 > +netdev_tx_t mac802154_tx(struct mac802154_priv *priv, struct sk_buff *skb, > + u8 page, u8 chan); Line up these arguments on the second line correctly! If you can't do it properly by hand, use something like emacs's "C mode" to do it for you automatically. > + res = xw->priv->ops->set_channel(&xw->priv->hw, > + xw->page, > + xw->chan); Line up the arguments properly. > + pr_debug("(%s): set_channel failed\n", __func__); Putting __func__ into the debugging printk's is excessive, take these out. > + if (WARN_ON(!(priv->phy->channels_supported[page] & > + (1 << chan)))) More poor formatting. ------------------------------------------------------------------------------ Learn Windows Azure Live! Tuesday, Dec 13, 2011 Microsoft is holding a special Learn Windows Azure training event for developers. It will provide a great way to learn Windows Azure and what it provides. You can attend the event by watching it streamed LIVE online. Learn more at http://p.sf.net/sfu/ms-windowsazure