From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 08/14] mac802154: basic mib support Date: Mon, 19 Dec 2011 14:39:59 -0500 (EST) Message-ID: <20111219.143959.1266018350656510.davem@davemloft.net> References: <20111219163117.GA13123@avtobot.cybertron> <1324312434-13151-8-git-send-email-alex.bluesman.smirnov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1324312434-13151-8-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org From: Alexander Smirnov Date: Mon, 19 Dec 2011 19:33:48 +0300 > + res = hw->ops->set_hw_addr_filt(&hw->hw, > + &hw->hw.hw_filt, nw->changed); Line up the arguments. > + pr_debug("%s: failed changed mask %lx\n", > + __func__, nw->changed); Get rid of __func__. > + if (priv->hw->ops->set_hw_addr_filt && > + memcmp(priv->hw->hw.hw_filt.ieee_addr, > + dev->dev_addr, IEEE802154_ADDR_LEN)) { More bad formatting. ------------------------------------------------------------------------------ Learn Windows Azure Live! Tuesday, Dec 13, 2011 Microsoft is holding a special Learn Windows Azure training event for developers. It will provide a great way to learn Windows Azure and what it provides. You can attend the event by watching it streamed LIVE online. Learn more at http://p.sf.net/sfu/ms-windowsazure