From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 10/14] ieee802154: interface type to be added Date: Mon, 19 Dec 2011 14:42:10 -0500 (EST) Message-ID: <20111219.144210.2223105215234869759.davem@davemloft.net> References: <20111219163117.GA13123@avtobot.cybertron> <1324312434-13151-10-git-send-email-alex.bluesman.smirnov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, alexander@Lenovo To: alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1324312434-13151-10-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org From: Alexander Smirnov Date: Mon, 19 Dec 2011 19:33:50 +0300 > int rc = -ENOBUFS; > struct net_device *dev; > + int type = -EINVAL; Bad indentation. Or do you mean to tell me this doesn't look like total garbage and stand out like a sore thumb on your computer screen? > + if (type > __IEEE802154_DEV_MAX) { > + return -EINVAL; > + } No need for openning and closing braces here, there is simply one statement in the basic block. If you'll need them later, add them later, not now. ------------------------------------------------------------------------------ Learn Windows Azure Live! Tuesday, Dec 13, 2011 Microsoft is holding a special Learn Windows Azure training event for developers. It will provide a great way to learn Windows Azure and what it provides. You can attend the event by watching it streamed LIVE online. Learn more at http://p.sf.net/sfu/ms-windowsazure