* [PATCH 4/6] sunhme/PCI: use list_for_each_entry() for bus->devices traversal [not found] <20111216223043.5963.87534.stgit@bhelgaas.mtv.corp.google.com> @ 2011-12-16 22:31 ` Bjorn Helgaas 2011-12-19 21:13 ` David Miller 2011-12-16 22:31 ` [PATCH 5/6] de4x5/PCI: " Bjorn Helgaas 1 sibling, 1 reply; 5+ messages in thread From: Bjorn Helgaas @ 2011-12-16 22:31 UTC (permalink / raw) To: Jesse Barnes; +Cc: linux-pci, David S. Miller, netdev Replace open-coded list traversal with list_for_each_entry(). CC: David S. Miller <davem@davemloft.net> CC: netdev@vger.kernel.org Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/net/ethernet/sun/sunhme.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c index cf14ab9..1d00a4c 100644 --- a/drivers/net/ethernet/sun/sunhme.c +++ b/drivers/net/ethernet/sun/sunhme.c @@ -2849,7 +2849,7 @@ err_out: static int is_quattro_p(struct pci_dev *pdev) { struct pci_dev *busdev = pdev->bus->self; - struct list_head *tmp; + struct pci_dev *this_pdev; int n_hmes; if (busdev == NULL || @@ -2858,15 +2858,10 @@ static int is_quattro_p(struct pci_dev *pdev) return 0; n_hmes = 0; - tmp = pdev->bus->devices.next; - while (tmp != &pdev->bus->devices) { - struct pci_dev *this_pdev = pci_dev_b(tmp); - + list_for_each_entry(this_pdev, &pdev->bus->devices, bus_list) { if (this_pdev->vendor == PCI_VENDOR_ID_SUN && this_pdev->device == PCI_DEVICE_ID_SUN_HAPPYMEAL) n_hmes++; - - tmp = tmp->next; } if (n_hmes != 4) ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 4/6] sunhme/PCI: use list_for_each_entry() for bus->devices traversal 2011-12-16 22:31 ` [PATCH 4/6] sunhme/PCI: use list_for_each_entry() for bus->devices traversal Bjorn Helgaas @ 2011-12-19 21:13 ` David Miller 0 siblings, 0 replies; 5+ messages in thread From: David Miller @ 2011-12-19 21:13 UTC (permalink / raw) To: bhelgaas; +Cc: jbarnes, linux-pci, netdev From: Bjorn Helgaas <bhelgaas@google.com> Date: Fri, 16 Dec 2011 15:31:49 -0700 > Replace open-coded list traversal with list_for_each_entry(). > > CC: David S. Miller <davem@davemloft.net> > CC: netdev@vger.kernel.org > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Applied. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 5/6] de4x5/PCI: use list_for_each_entry() for bus->devices traversal [not found] <20111216223043.5963.87534.stgit@bhelgaas.mtv.corp.google.com> 2011-12-16 22:31 ` [PATCH 4/6] sunhme/PCI: use list_for_each_entry() for bus->devices traversal Bjorn Helgaas @ 2011-12-16 22:31 ` Bjorn Helgaas 2011-12-16 22:34 ` Grant Grundler 2011-12-19 21:13 ` David Miller 1 sibling, 2 replies; 5+ messages in thread From: Bjorn Helgaas @ 2011-12-16 22:31 UTC (permalink / raw) To: Jesse Barnes; +Cc: linux-pci, Grant Grundler, netdev Replace open-coded list traversal with list_for_each_entry(). CC: Grant Grundler <grundler@parisc-linux.org> CC: netdev@vger.kernel.org Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/net/ethernet/dec/tulip/de4x5.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c index 871bcaa..3f5d3b9 100644 --- a/drivers/net/ethernet/dec/tulip/de4x5.c +++ b/drivers/net/ethernet/dec/tulip/de4x5.c @@ -2127,14 +2127,9 @@ srom_search(struct net_device *dev, struct pci_dev *pdev) u_long iobase = 0; /* Clear upper 32 bits in Alphas */ int i, j; struct de4x5_private *lp = netdev_priv(dev); - struct list_head *walk; - - list_for_each(walk, &pdev->bus_list) { - struct pci_dev *this_dev = pci_dev_b(walk); - - /* Skip the pci_bus list entry */ - if (list_entry(walk, struct pci_bus, devices) == pdev->bus) continue; + struct pci_dev *this_dev; + list_for_each_entry(this_dev, &pdev->bus->devices, bus_list) { vendor = this_dev->vendor; device = this_dev->device << 8; if (!(is_DC21040 || is_DC21041 || is_DC21140 || is_DC2114x)) continue; ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 5/6] de4x5/PCI: use list_for_each_entry() for bus->devices traversal 2011-12-16 22:31 ` [PATCH 5/6] de4x5/PCI: " Bjorn Helgaas @ 2011-12-16 22:34 ` Grant Grundler 2011-12-19 21:13 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: Grant Grundler @ 2011-12-16 22:34 UTC (permalink / raw) To: Bjorn Helgaas; +Cc: Jesse Barnes, linux-pci, Grant Grundler, netdev On Fri, Dec 16, 2011 at 2:31 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: > Replace open-coded list traversal with list_for_each_entry(). Hi Bjorn, I don't have any de4x5 devices to test this but it looks correct to me. Thanks! grant > > CC: Grant Grundler <grundler@parisc-linux.org> > CC: netdev@vger.kernel.org > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/net/ethernet/dec/tulip/de4x5.c | 9 ++------- > 1 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c > index 871bcaa..3f5d3b9 100644 > --- a/drivers/net/ethernet/dec/tulip/de4x5.c > +++ b/drivers/net/ethernet/dec/tulip/de4x5.c > @@ -2127,14 +2127,9 @@ srom_search(struct net_device *dev, struct pci_dev *pdev) > u_long iobase = 0; /* Clear upper 32 bits in Alphas */ > int i, j; > struct de4x5_private *lp = netdev_priv(dev); > - struct list_head *walk; > - > - list_for_each(walk, &pdev->bus_list) { > - struct pci_dev *this_dev = pci_dev_b(walk); > - > - /* Skip the pci_bus list entry */ > - if (list_entry(walk, struct pci_bus, devices) == pdev->bus) continue; > + struct pci_dev *this_dev; > > + list_for_each_entry(this_dev, &pdev->bus->devices, bus_list) { > vendor = this_dev->vendor; > device = this_dev->device << 8; > if (!(is_DC21040 || is_DC21041 || is_DC21140 || is_DC2114x)) continue; > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/6] de4x5/PCI: use list_for_each_entry() for bus->devices traversal 2011-12-16 22:31 ` [PATCH 5/6] de4x5/PCI: " Bjorn Helgaas 2011-12-16 22:34 ` Grant Grundler @ 2011-12-19 21:13 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: David Miller @ 2011-12-19 21:13 UTC (permalink / raw) To: bhelgaas; +Cc: jbarnes, linux-pci, grundler, netdev From: Bjorn Helgaas <bhelgaas@google.com> Date: Fri, 16 Dec 2011 15:31:54 -0700 > Replace open-coded list traversal with list_for_each_entry(). > > CC: Grant Grundler <grundler@parisc-linux.org> > CC: netdev@vger.kernel.org > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Applied. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-19 21:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20111216223043.5963.87534.stgit@bhelgaas.mtv.corp.google.com>
2011-12-16 22:31 ` [PATCH 4/6] sunhme/PCI: use list_for_each_entry() for bus->devices traversal Bjorn Helgaas
2011-12-19 21:13 ` David Miller
2011-12-16 22:31 ` [PATCH 5/6] de4x5/PCI: " Bjorn Helgaas
2011-12-16 22:34 ` Grant Grundler
2011-12-19 21:13 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).