From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: timo.teras@iki.fi, netdev@vger.kernel.org
Subject: Re: linux-3.0.x regression with ipv4 routes having mtu
Date: Tue, 20 Dec 2011 13:35:42 -0500 (EST) [thread overview]
Message-ID: <20111220.133542.2144336048061483258.davem@davemloft.net> (raw)
In-Reply-To: <20111220071843.GL6348@secunet.com>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Tue, 20 Dec 2011 08:18:43 +0100
> On Tue, Dec 20, 2011 at 02:03:55AM -0500, David Miller wrote:
>> From: Timo Teräs <timo.teras@iki.fi>
>> Date: Tue, 20 Dec 2011 08:53:09 +0200
>>
>> > Or maybe I missed the place where that updated would happen?
>>
>> It should happen on every routing cache lookup hit just like we
>> validate the peer for redirect information.
>
> The problem is that we need to do a route cache lookup to
> validate the peer informations. This does not happen if
> somebody adds a new route. I tried already to add a pmtu specific
> generation id and it appears to not solve the problem. We would
> still need to overwrite the cached value if we add a route with mtu.
Why?
Every use of a routing cache entry does a dst_check() or a routing
cache lookup.
You can check the generation ID in both locations, and if the
comparison fails then you force the routing cache entry to be killed
and the caller performs a lookup. At that time the refreshing of the
new FIB entry will be realized.
The critical bit is invalidating the routing cache entry, I can only
guess that you're not doing that.
next prev parent reply other threads:[~2011-12-20 18:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 15:54 linux-3.0.x regression with ipv4 routes having mtu Timo Teräs
2011-12-14 17:50 ` David Miller
2011-12-14 17:57 ` Eric Dumazet
2011-12-14 18:22 ` Timo Teräs
2011-12-15 13:49 ` Steffen Klassert
2011-12-16 12:21 ` Steffen Klassert
2011-12-16 14:30 ` Timo Teräs
2011-12-19 13:52 ` Steffen Klassert
2011-12-19 20:09 ` David Miller
2011-12-20 8:03 ` Steffen Klassert
2011-12-19 21:10 ` David Miller
2011-12-20 6:53 ` Timo Teräs
2011-12-20 7:03 ` David Miller
2011-12-20 7:18 ` Steffen Klassert
2011-12-20 18:35 ` David Miller [this message]
2011-12-21 8:56 ` Steffen Klassert
2011-12-21 20:56 ` David Miller
2011-12-22 10:25 ` Steffen Klassert
2011-12-22 18:51 ` David Miller
2011-12-23 8:47 ` Steffen Klassert
2011-12-23 9:00 ` David Miller
2011-12-23 8:58 ` Steffen Klassert
2012-02-02 10:01 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220.133542.2144336048061483258.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).