From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars Date: Tue, 20 Dec 2011 14:02:09 -0500 (EST) Message-ID: <20111220.140209.618109781658024408.davem@davemloft.net> References: <1324377504-20983-1-git-send-email-lindner_marek@yahoo.de> <20111220.133230.713811345652751674.davem@davemloft.net> <201112210259.42387.lindner_marek@yahoo.de> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org To: lindner_marek-LWAfsSFWpa4@public.gmane.org Return-path: In-Reply-To: <201112210259.42387.lindner_marek-LWAfsSFWpa4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org From: Marek Lindner Date: Wed, 21 Dec 2011 02:59:41 +0800 > On Wednesday, December 21, 2011 02:32:30 David Miller wrote: >> From: Marek Lindner >> Date: Tue, 20 Dec 2011 18:38:24 +0800 >> >> > The long line was introduced with b26e478f8f. >> > >> > Signed-off-by: Marek Lindner >> >> I'm not applying this. >> >> I tell people to make sure arguments line up correctly to the >> openning parenthesis on the previous line, and that is what is >> happening here. > > I am not against lining up the arguments but what about checkpatch ? Are we > going to ignore the complaints or is this line limit about to be changed ? Refactor the code so that both constraints can be satisfied. Is this so hard to understand?