From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xi.wang@gmail.com, therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] rps: fix insufficient bounds checking in store_rps_dev_flow_table_cnt()
Date: Wed, 21 Dec 2011 14:41:26 -0500 (EST) [thread overview]
Message-ID: <20111221.144126.2213051521357190879.davem@davemloft.net> (raw)
In-Reply-To: <1324495344.2621.5.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 21 Dec 2011 20:22:24 +0100
> Le mercredi 21 décembre 2011 à 13:50 -0500, Xi Wang a écrit :
>> @@ -665,7 +665,7 @@ static ssize_t store_rps_dev_flow_table_cnt(struct netdev_rx_queue *queue,
>> if (count) {
>> int i;
>>
>> - if (count > 1<<30) {
>> + if (count > 1<<28) {
>> /* Enforce a limit to prevent overflow */
>> return -EINVAL;
>> }
>
>
> Really, you should remove this magic number and use instead
>
> (INT_MAX - RPS_DEV_FLOW_TABLE_SIZE(0)) / sizeof(struct rps_dev_flow)
>
> Or something like that, because next time we add a field in
> rps_dev_flow, test will be obsolete.
Agreed.
next prev parent reply other threads:[~2011-12-21 19:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 18:50 [PATCH] rps: fix insufficient bounds checking in store_rps_dev_flow_table_cnt() Xi Wang
2011-12-21 19:22 ` Eric Dumazet
2011-12-21 19:41 ` David Miller [this message]
2011-12-21 23:41 ` Xi Wang
2011-12-22 23:35 ` [PATCH v2] " Xi Wang
2011-12-23 3:37 ` David Miller
2011-12-23 4:10 ` Eric Dumazet
2011-12-23 4:44 ` Xi Wang
2011-12-23 4:53 ` Eric Dumazet
2011-12-23 5:10 ` Xi Wang
2011-12-23 5:16 ` Eric Dumazet
2011-12-23 5:35 ` Eric Dumazet
2011-12-23 5:56 ` Xi Wang
2011-12-23 13:06 ` Eric Dumazet
2011-12-23 14:30 ` Xi Wang
2011-12-23 14:53 ` Eric Dumazet
2011-12-23 15:07 ` Xi Wang
2011-12-24 16:56 ` [PATCH net-next] rfs: better sizing of dev_flow_table Eric Dumazet
2011-12-24 21:19 ` David Miller
2011-12-23 5:49 ` [PATCH v2] rps: fix insufficient bounds checking in store_rps_dev_flow_table_cnt() Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221.144126.2213051521357190879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).