From: David Miller <davem@davemloft.net>
To: subramanian.vijay@gmail.com
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru
Subject: Re: [PATCH net-next] tcp: Fix bug in ofo queue pruning MIB stats
Date: Wed, 21 Dec 2011 19:33:15 -0500 (EST) [thread overview]
Message-ID: <20111221.193315.2134174670572741208.davem@davemloft.net> (raw)
In-Reply-To: <1324511401-2640-1-git-send-email-subramanian.vijay@gmail.com>
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Wed, 21 Dec 2011 15:50:01 -0800
> Linux MIB LINUX_MIB_OFOPRUNED is supposed to count the number of packets
> dropped from the out-of-order queue due to socket buffer overrun. Instead
> of counting the number of skbs freed, it counts the number of calls make to
> __skb_queue_purge() which is not what the user (see f.e. netstat) is expecting.
> Fix this by incrementing the counter correctly.
>
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
I disagree, this is an event, and the counter is counting how many times
we prune the out of order queue, not how many packets we prune from that
queue.
next prev parent reply other threads:[~2011-12-22 0:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 23:50 [PATCH net-next] tcp: Fix bug in ofo queue pruning MIB stats Vijay Subramanian
2011-12-22 0:33 ` David Miller [this message]
2011-12-22 1:14 ` Vijay Subramanian
2011-12-22 3:15 ` David Miller
2012-01-03 23:10 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221.193315.2134174670572741208.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=subramanian.vijay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).