From: Mircea Gherzan <mgherzan@gmail.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Rob Herring <robherring2@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux@arm.linux.org.uk
Subject: Re: [PATCH] ARM: net: JIT compiler for packet filters
Date: Wed, 21 Dec 2011 16:36:03 +0200 [thread overview]
Message-ID: <20111221143602.GA3229@swarm.cs.pub.ro> (raw)
In-Reply-To: <alpine.LFD.2.02.1112191226160.2907@xanadu.home>
On Mon, Dec 19, 2011 at 12:31:19PM -0500, Nicolas Pitre wrote:
> On Sun, 18 Dec 2011, Rob Herring wrote:
>
> > On 12/18/2011 05:49 PM, Mircea Gherzan wrote:
> > > + select HAVE_BPF_JIT if (!THUMB2_KERNEL && AEABI)
> >
> > No thumb2. That's a shame...
>
> I think this would be more sensible to make a Thumb2 kernel properly
> interoperate with this and keep the JIT code simple rather than having
> to duplicate all this for Thumb2.
The JITed code interoperates properly with a Thumb2 kernel as of v3 of
the patch.
> > BLX is v5+ only. It probably fine to make the JIT v5+ only. There's
> > probably not much v4 h/w that would use this.
>
> While you might be right, I don't think it is that big a cost to make
> this support ARMv4 too. In fact, if slow ARMv4 systems are still
> routing packets out there, they are likely to see a huge benefit from
> this.
This has also been addressed in v3.
Mircea
next prev parent reply other threads:[~2011-12-21 14:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 23:49 [PATCH] ARM: net: JIT compiler for packet filters Mircea Gherzan
2011-12-19 2:26 ` Ben Hutchings
2011-12-19 2:49 ` Rob Herring
2011-12-19 17:31 ` Nicolas Pitre
2011-12-21 14:36 ` Mircea Gherzan [this message]
2011-12-19 17:42 ` Nicolas Pitre
2011-12-21 14:43 ` Mircea Gherzan
2011-12-21 15:07 ` Nicolas Pitre
-- strict thread matches above, loose matches on Subject: below --
2011-12-18 23:48 Mircea Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221143602.GA3229@swarm.cs.pub.ro \
--to=mgherzan@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).