From: Christoph Hellwig <hch@infradead.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: netdev@vger.kernel.org, Thomas Graf <tgraf@infradead.org>,
"David S. Miller" <davem@davemloft.net>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] vfs: Export some file manipulation functions
Date: Wed, 21 Dec 2011 10:30:54 -0500 [thread overview]
Message-ID: <20111221153054.GA1489@infradead.org> (raw)
In-Reply-To: <1324478390-22036-3-git-send-email-nhorman@tuxdriver.com>
On Wed, Dec 21, 2011 at 09:39:48AM -0500, Neil Horman wrote:
> the networking cgroups can use the fd table of a task to make adjustments to the
> sockets that they own, helping us set owners for various resources. Export
> get_files_struct, put_files_struct and sock_from_file, so we can walk a tasks
> fdarray easily.
No, no one has any business using these lowlevel routines form modules.
Please find a way to do this in core code, or find more highlevel
primitives to export.
And not even Ccing linux-fsdevel on a change like this is one of the few
things I'd consider extremely offensive.
next prev parent reply other threads:[~2011-12-21 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 14:39 [PATCH 0/4] net: Improve socket sharing between multiple cgroups Neil Horman
2011-12-21 14:39 ` [PATCH 1/4] net_prio/classid: add cgroup process ownership filter Neil Horman
2011-12-21 14:39 ` [PATCH 2/4] vfs: Export some file manipulation functions Neil Horman
2011-12-21 15:30 ` Christoph Hellwig [this message]
2011-12-21 16:42 ` Neil Horman
2011-12-21 14:39 ` [PATCH 3/4] net: use cgroup_attach method to migrate socket priotiy and classid Neil Horman
2011-12-21 15:40 ` Al Viro
2011-12-21 14:39 ` [PATCH 4/4] net: remove no-longer needed calls to sock_update_[classid|netprioix] Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221153054.GA1489@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).