From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Chris Boot <bootc@bootc.net>, lkml <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: BUG: unable to handle kernel NULL pointer dereference in ipv6_select_ident
Date: Thu, 22 Dec 2011 07:38:06 +0100 [thread overview]
Message-ID: <20111222063806.GP6348@secunet.com> (raw)
In-Reply-To: <1324528656.2621.19.camel@edumazet-laptop>
On Thu, Dec 22, 2011 at 05:37:36AM +0100, Eric Dumazet wrote:
> Le mercredi 21 décembre 2011 à 23:12 +0000, Chris Boot a écrit :
> >
> > (gdb) list *ip_fragment+0x9d
> > 0xffffffff812a62e1 is in ip_fragment (include/net/dst.h:209).
> > 204 return dst_metric(dst, RTAX_FEATURES) & feature;
> > 205 }
> > 206
> > 207 static inline u32 dst_mtu(const struct dst_entry *dst)
> > 208 {
> > 209 return dst->ops->mtu(dst);
> > 210 }
> > 211
> > 212 /* RTT metrics are stored in milliseconds for user ABI, but used as jiffies */
>
> This one is different, its not IPv6 related but IPv4 :
>
> fake_dst_ops lacks a .mtu() field
>
> Bug added in commit 618f9bc74a039da76 (net: Move mtu handling down to
> the protocol depended handlers)
>
Before I did this patch, I changed the .default_mtu field of "struct dst_ops"
to .mtu and converted all users of default_mtu to mtu. fake_dst_ops never
had a default_mtu field, so I did not touch it. I guess this bug is arround
since fake_dst_ops exists. It's now just much easier to trigger as commit
618f9bc74a039da76 changed dst_mtu() to call dst->ops->mtu() unconditionally.
next prev parent reply other threads:[~2011-12-22 6:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4EF200BB.7000209@bootc.net>
2011-12-21 16:29 ` BUG: unable to handle kernel NULL pointer dereference in ipv6_select_ident Eric Dumazet
2011-12-21 17:03 ` Chris Boot
2011-12-21 17:36 ` Eric Dumazet
2011-12-21 18:00 ` Eric Dumazet
2011-12-21 20:05 ` Chris Boot
2011-12-21 20:28 ` Eric Dumazet
2011-12-21 20:52 ` Eric Dumazet
2011-12-21 21:58 ` Chris Boot
2011-12-21 23:12 ` Chris Boot
2011-12-22 4:37 ` Eric Dumazet
2011-12-22 6:00 ` [PATCH] bridge: provide a mtu() method for fake_dst_ops Eric Dumazet
2011-12-22 7:05 ` Steffen Klassert
2011-12-22 6:38 ` Steffen Klassert [this message]
2011-12-22 7:51 ` BUG: unable to handle kernel NULL pointer dereference in ipv6_select_ident Eric Dumazet
2011-12-22 7:58 ` Steffen Klassert
2011-12-22 8:05 ` Eric Dumazet
2011-12-22 10:01 ` Steffen Klassert
2011-12-22 10:04 ` Chris Boot
2011-12-22 14:15 ` Eric Dumazet
2011-12-22 15:54 ` Chris Boot
2011-12-22 17:41 ` Eric Dumazet
2011-12-22 18:29 ` David Miller
2011-12-23 3:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222063806.GP6348@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=bootc@bootc.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).