From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Chris Boot <bootc@bootc.net>, lkml <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: BUG: unable to handle kernel NULL pointer dereference in ipv6_select_ident
Date: Thu, 22 Dec 2011 08:58:30 +0100 [thread overview]
Message-ID: <20111222075830.GR6348@secunet.com> (raw)
In-Reply-To: <1324540277.2621.41.camel@edumazet-laptop>
On Thu, Dec 22, 2011 at 08:51:17AM +0100, Eric Dumazet wrote:
>
> Prior to 618f9bc74a0, we were calling
>
> static inline u32 dst_mtu(const struct dst_entry *dst)
> {
> u32 mtu = dst_metric_raw(dst, RTAX_MTU);
>
> if (!mtu)
> mtu = dst->ops->mtu(dst);
>
> return mtu;
> }
>
> with dst = fake_rtable
>
> and we did :
>
> dst_init_metrics(&rt->dst, br_dst_default_metrics, true);
>
> so dst_metric_raw(dst, RTAX_MTU) was returning 1500
>
> So bug is new, we dont need to backport this fix.
>
Ok, I see. Thanks for pointing it out!
next prev parent reply other threads:[~2011-12-22 7:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4EF200BB.7000209@bootc.net>
2011-12-21 16:29 ` BUG: unable to handle kernel NULL pointer dereference in ipv6_select_ident Eric Dumazet
2011-12-21 17:03 ` Chris Boot
2011-12-21 17:36 ` Eric Dumazet
2011-12-21 18:00 ` Eric Dumazet
2011-12-21 20:05 ` Chris Boot
2011-12-21 20:28 ` Eric Dumazet
2011-12-21 20:52 ` Eric Dumazet
2011-12-21 21:58 ` Chris Boot
2011-12-21 23:12 ` Chris Boot
2011-12-22 4:37 ` Eric Dumazet
2011-12-22 6:00 ` [PATCH] bridge: provide a mtu() method for fake_dst_ops Eric Dumazet
2011-12-22 7:05 ` Steffen Klassert
2011-12-22 6:38 ` BUG: unable to handle kernel NULL pointer dereference in ipv6_select_ident Steffen Klassert
2011-12-22 7:51 ` Eric Dumazet
2011-12-22 7:58 ` Steffen Klassert [this message]
2011-12-22 8:05 ` Eric Dumazet
2011-12-22 10:01 ` Steffen Klassert
2011-12-22 10:04 ` Chris Boot
2011-12-22 14:15 ` Eric Dumazet
2011-12-22 15:54 ` Chris Boot
2011-12-22 17:41 ` Eric Dumazet
2011-12-22 18:29 ` David Miller
2011-12-23 3:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222075830.GR6348@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=bootc@bootc.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).