Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: netdev@vger.kernel.org, shawn.guo@freescale.com,
	kernel@pengutronix.de, rogerio.pimentel@freescale.com,
	fabio.estevam@freescale.com
Subject: Re: [PATCH] net: fec: Adjust ENET MDIO timeouts
Date: Tue, 27 Dec 2011 13:13:44 -0500 (EST)	[thread overview]
Message-ID: <20111227.131344.1087161640480826569.davem@davemloft.net> (raw)
In-Reply-To: <1324997198-2241-1-git-send-email-festevam@gmail.com>

From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 27 Dec 2011 12:46:38 -0200

> -#define FEC_MII_TIMEOUT		1000 /* us */
> +#define FEC_MII_TIMEOUT		30 /* ms */

I don't see why you must use msecs_to_jiffies(), why not just change
FEC_MII_TIMEOUT to 30000?

That's a one-line, easy to validate, change.

Whereas if you also change the units of the timeout I have to go
through the entire driver to audit your patch, making sure none of the
FEC_MII_TIMEOUT uses in the driver have been missed.

When you make multiple changes at once, it leads to more work for the
patch reviewer, please avoid this whenever possible.

Thanks.

  reply	other threads:[~2011-12-27 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 14:46 [PATCH] net: fec: Adjust ENET MDIO timeouts Fabio Estevam
2011-12-27 18:13 ` David Miller [this message]
2011-12-27 18:53 ` [PATCH v2] " Fabio Estevam
2011-12-27 19:07   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111227.131344.1087161640480826569.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=rogerio.pimentel@freescale.com \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox