From: Stephen Hemminger <shemminger@vyatta.com>
To: Joshua Kinard <kumba@gentoo.org>
Cc: netdev@vger.kernel.org, Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery
Date: Tue, 27 Dec 2011 14:34:41 -0800 [thread overview]
Message-ID: <20111227143441.30d2c42f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <4EFA38D5.1000602@gentoo.org>
On Tue, 27 Dec 2011 16:29:57 -0500
Joshua Kinard <kumba@gentoo.org> wrote:
> MIPS I/O registers are always memory-mapped, and to prevent the compiler
> from trying to over-optimize, volatile is used to make sure we always read a
> value from the hardware and not from some cached value.
Almost every other network driver had memory mapped register.
The problem is volatile is that the compiler is stupid and wrong.
Using explicit barriers is preferred and ensures correct and fast
code.
next prev parent reply other threads:[~2011-12-27 22:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 0:56 [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery Joshua Kinard
2011-12-18 2:56 ` David Miller
2011-12-18 4:37 ` Joshua Kinard
2011-12-18 5:19 ` David Miller
2011-12-18 14:40 ` Joshua Kinard
2011-12-18 15:13 ` Joshua Kinard
2011-12-18 13:26 ` Sergei Shtylyov
2011-12-18 14:35 ` Joshua Kinard
2011-12-25 1:45 ` Joshua Kinard
2011-12-26 20:17 ` David Miller
2011-12-27 4:54 ` Joshua Kinard
2011-12-27 5:06 ` Joshua Kinard
2011-12-27 18:17 ` David Miller
2011-12-27 18:34 ` Stephen Hemminger
2011-12-27 18:52 ` David Miller
2011-12-27 21:29 ` Joshua Kinard
2011-12-27 22:34 ` Stephen Hemminger [this message]
2011-12-27 22:48 ` Joshua Kinard
2011-12-28 0:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111227143441.30d2c42f@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).