From: David Miller <davem@davemloft.net>
To: alex.bluesman.smirnov@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 02/14 v2] mac802154: allocation of ieee802154 device
Date: Wed, 28 Dec 2011 02:31:45 -0500 (EST) [thread overview]
Message-ID: <20111228.023145.2078199792492848729.davem@davemloft.net> (raw)
In-Reply-To: <CAJmB2rAyyPmYTmtTvFK3UuFn9t+361raA5R=92XPNHrH7dfgfw@mail.gmail.com>
From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Date: Wed, 28 Dec 2011 10:19:23 +0300
> Dear David,
>
> 2011/12/26 David Miller <davem@davemloft.net>:
>> From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
>> Date: Mon, 26 Dec 2011 20:04:07 +0300
>>
>>> + /*
>>> + * SoftMAC device is registered and running. One can add
>>> + * subinterfaces.
>>> + */
>>> + unsigned running:1;
>>
>> I told you to change this to a 'bool' in my previous review of your changes.
>>
>> I'm pretty much going to stop reviewing right here, because I don't
>> want to waste my time only to find out that you've ignored other
>> review feedback I've already given to you.
>>
>
> Regarding your comments to my previous post, none of them was omitted. I
> reworked code according to them and added extended comments in a patch
> explaining why I can't follow your hint. The issue with 'bool' you marked
> was in another patch (#14) which I already fixed.
My bad, I thought I had asked you do it here too.
Sorry about that.
next prev parent reply other threads:[~2011-12-28 7:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 16:01 [PATCH series v2] IEEE 802.15.4 MAC layer basic implementation Alexander Smirnov
2011-12-26 17:05 ` [PATCH 04/14 v2] mac802154: TX data path Alexander Smirnov
2011-12-26 17:06 ` [PATCH 05/14 v2] mac802154: define reduced mlme operations Alexander Smirnov
2011-12-26 17:07 ` [PATCH 06/14 v2] mac802154: slave interfaces definition Alexander Smirnov
2011-12-26 17:09 ` [PATCH 07/14 v2] mac802154: reduced mlme operations Alexander Smirnov
2011-12-26 17:09 ` [PATCH 08/14 v2] mac802154: basic mib support Alexander Smirnov
2011-12-26 17:11 ` [PATCH 10/14 v2] ieee802154: interface type to be added Alexander Smirnov
2011-12-26 17:11 ` [PATCH 11/14 v2] mac802154: slaves manipulation routine Alexander Smirnov
2011-12-26 17:12 ` [PATCH 12/14 v2] mac802154: monitor device support Alexander Smirnov
[not found] ` <CAJmB2rBMVvw_TV-mT2-jT7=H0adfMWaYFC0Q908pc_ND+PLD_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-26 17:02 ` [PATCH 01/14 v2] mac802154: basic ieee802.15.4 device structures Alexander Smirnov
[not found] ` <1324918953-14813-1-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-26 20:07 ` David Miller
2011-12-26 17:04 ` [PATCH 02/14 v2] mac802154: allocation of ieee802154 device Alexander Smirnov
[not found] ` <1324919047-14851-1-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-26 20:09 ` David Miller
2011-12-28 7:19 ` Alexander Smirnov
2011-12-28 7:31 ` David Miller [this message]
2012-01-05 14:11 ` Alexander Smirnov
2011-12-26 17:04 ` [PATCH 03/14 v2] mac802154: RX data path Alexander Smirnov
2011-12-26 17:10 ` [PATCH 09/14 v2] ieee802154: remove ieee802154 policy from globals Alexander Smirnov
2011-12-26 17:12 ` [PATCH 13/14 v2] drivers/ieee802154: IEEE 802.15.4 loopback driver Alexander Smirnov
2011-12-26 17:13 ` [PATCH 14/14 v2] Documentation/networking/ieee802154: update MAC chapter Alexander Smirnov
2011-12-26 17:57 ` [PATCH series v2] IEEE 802.15.4 MAC layer basic implementation Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228.023145.2078199792492848729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox