From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] genetlink: add auto module loading
Date: Wed, 28 Dec 2011 14:03:15 -0500 (EST) [thread overview]
Message-ID: <20111228.140315.1485215996445763095.davem@davemloft.net> (raw)
In-Reply-To: <20111228110208.5f6de3d8@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 28 Dec 2011 11:02:08 -0800
> On Wed, 28 Dec 2011 13:49:39 -0500 (EST)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Stephen Hemminger <shemminger@vyatta.com>
>> Date: Wed, 28 Dec 2011 10:19:58 -0800
>>
>> > When testing L2TP support, I discovered that the l2tp module is not autoloaded
>> > as are other netlink interfaces. There is because of lack of hook in genetlink to call
>> > request_module and load the module.
>> >
>> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>> Applied, but for completeness we should probably also handle the "by ID" case right
>> above this code block too.
>>
>> Could you please submit a patch for that?
>>
>> Thanks.
>
> There is no point really. All the existing drivers,
> use GENL_ID_GENERATE which generates the ID when they are loaded.
> Chicken and egg principle.
Ok, then I wonder why we support ID based lookups at all.
prev parent reply other threads:[~2011-12-28 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 18:19 [PATCH] genetlink: add auto module loading Stephen Hemminger
2011-12-28 18:49 ` David Miller
2011-12-28 19:02 ` Stephen Hemminger
2011-12-28 19:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228.140315.1485215996445763095.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).