* [PATCH] skge: restore multicast rx filter on resume
@ 2011-12-25 8:18 Florian Zumbiehl
2011-12-26 20:17 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Florian Zumbiehl @ 2011-12-25 8:18 UTC (permalink / raw)
To: netdev, shemminger
Hi,
no clue whether this is really the correct[tm] way to fix this, but it
makes it so that IPv6 doesn't start failing after a suspend/resume cycle
because neighbour discovery stops working ...
Florian
---------------------------------------------------------------------------
skge: restore multicast rx filter on resume
Signed-off-by: Florian Zumbiehl <florz@florz.de>
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index f4be5c7..cd968e5 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
dev_close(dev);
goto out;
}
+ skge_set_multicast(dev);
}
}
out:
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-25 8:18 [PATCH] skge: restore multicast rx filter on resume Florian Zumbiehl
@ 2011-12-26 20:17 ` David Miller
2011-12-27 17:56 ` Stephen Hemminger
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2011-12-26 20:17 UTC (permalink / raw)
To: florz; +Cc: netdev, shemminger
From: Florian Zumbiehl <florz@florz.de>
Date: Sun, 25 Dec 2011 09:18:33 +0100
> skge: restore multicast rx filter on resume
>
> Signed-off-by: Florian Zumbiehl <florz@florz.de>
Stephen? This one looks fine to me.
> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> index f4be5c7..cd968e5 100644
> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c
> @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
> dev_close(dev);
> goto out;
> }
> + skge_set_multicast(dev);
> }
> }
> out:
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-26 20:17 ` David Miller
@ 2011-12-27 17:56 ` Stephen Hemminger
2011-12-28 7:41 ` Florian Zumbiehl
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2011-12-27 17:56 UTC (permalink / raw)
To: David Miller; +Cc: florz, netdev
On Mon, 26 Dec 2011 15:17:54 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Florian Zumbiehl <florz@florz.de>
> Date: Sun, 25 Dec 2011 09:18:33 +0100
>
> > skge: restore multicast rx filter on resume
> >
> > Signed-off-by: Florian Zumbiehl <florz@florz.de>
>
> Stephen? This one looks fine to me.
>
> > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> > index f4be5c7..cd968e5 100644
> > --- a/drivers/net/skge.c
> > +++ b/drivers/net/skge.c
> > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
> > dev_close(dev);
> > goto out;
> > }
> > + skge_set_multicast(dev);
> > }
> > }
> > out:
Right idea, but it needs to be done in a different spot to catch
all the other device restart cases like changing settings.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-27 17:56 ` Stephen Hemminger
@ 2011-12-28 7:41 ` Florian Zumbiehl
2011-12-28 17:27 ` Stephen Hemminger
0 siblings, 1 reply; 9+ messages in thread
From: Florian Zumbiehl @ 2011-12-28 7:41 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, netdev
Hi,
> > > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> > > index f4be5c7..cd968e5 100644
> > > --- a/drivers/net/skge.c
> > > +++ b/drivers/net/skge.c
> > > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
> > > dev_close(dev);
> > > goto out;
> > > }
> > > + skge_set_multicast(dev);
> > > }
> > > }
> > > out:
>
> Right idea, but it needs to be done in a different spot to catch
> all the other device restart cases like changing settings.
Roughly like this maybe? (Successfully tested with an MTU change ...)
Florian
---------------------------------------------------------------------------
skge: restore rx multicast filter on resume
Signed-off-by: Florian Zumbiehl <florz@florz.de>
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index f4be5c7..8f985a8 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
spin_unlock_irq(&hw->hw_lock);
napi_enable(&skge->napi);
+
+ skge_set_multicast(dev);
+
return 0;
free_rx_ring:
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-28 7:41 ` Florian Zumbiehl
@ 2011-12-28 17:27 ` Stephen Hemminger
2011-12-28 18:09 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2011-12-28 17:27 UTC (permalink / raw)
To: Florian Zumbiehl; +Cc: David Miller, netdev
On Wed, 28 Dec 2011 08:41:43 +0100
Florian Zumbiehl <florz@florz.de> wrote:
> Hi,
>
> > > > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> > > > index f4be5c7..cd968e5 100644
> > > > --- a/drivers/net/skge.c
> > > > +++ b/drivers/net/skge.c
> > > > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
> > > > dev_close(dev);
> > > > goto out;
> > > > }
> > > > + skge_set_multicast(dev);
> > > > }
> > > > }
> > > > out:
> >
> > Right idea, but it needs to be done in a different spot to catch
> > all the other device restart cases like changing settings.
>
> Roughly like this maybe? (Successfully tested with an MTU change ...)
>
> Florian
>
> ---------------------------------------------------------------------------
> skge: restore rx multicast filter on resume
>
> Signed-off-by: Florian Zumbiehl <florz@florz.de>
>
> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> index f4be5c7..8f985a8 100644
> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c
> @@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
> spin_unlock_irq(&hw->hw_lock);
>
> napi_enable(&skge->napi);
> +
> + skge_set_multicast(dev);
> +
> return 0;
>
> free_rx_ring:
Looks good. That is (basically) the same as the patch I was testing.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-28 17:27 ` Stephen Hemminger
@ 2011-12-28 18:09 ` David Miller
2011-12-29 6:48 ` Florian Zumbiehl
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2011-12-28 18:09 UTC (permalink / raw)
To: shemminger; +Cc: florz, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 28 Dec 2011 09:27:14 -0800
> On Wed, 28 Dec 2011 08:41:43 +0100
> Florian Zumbiehl <florz@florz.de> wrote:
>
>> Hi,
>>
>> > > > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
>> > > > index f4be5c7..cd968e5 100644
>> > > > --- a/drivers/net/skge.c
>> > > > +++ b/drivers/net/skge.c
>> > > > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
>> > > > dev_close(dev);
>> > > > goto out;
>> > > > }
>> > > > + skge_set_multicast(dev);
>> > > > }
>> > > > }
>> > > > out:
>> >
>> > Right idea, but it needs to be done in a different spot to catch
>> > all the other device restart cases like changing settings.
>>
>> Roughly like this maybe? (Successfully tested with an MTU change ...)
>>
>> Florian
>>
>> ---------------------------------------------------------------------------
>> skge: restore rx multicast filter on resume
>>
>> Signed-off-by: Florian Zumbiehl <florz@florz.de>
>>
>> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
>> index f4be5c7..8f985a8 100644
>> --- a/drivers/net/skge.c
>> +++ b/drivers/net/skge.c
>> @@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
>> spin_unlock_irq(&hw->hw_lock);
>>
>> napi_enable(&skge->napi);
>> +
>> + skge_set_multicast(dev);
>> +
>> return 0;
>>
>> free_rx_ring:
>
> Looks good. That is (basically) the same as the patch I was testing.
>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Florian, please formally resubmit this with proper changelog and
Stephen's ack.
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-28 18:09 ` David Miller
@ 2011-12-29 6:48 ` Florian Zumbiehl
2011-12-29 7:56 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Florian Zumbiehl @ 2011-12-29 6:48 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, netdev
Hi,
> Florian, please formally resubmit this with proper changelog and
> Stephen's ack.
Erm, yeah, indeed. Well, there you go ...
Florian
---------------------------------------------------------------------------
skge: restore rx multicast filter on resume and after config changes
Restore skge hardware registers for multicast filtering to their
appropriate values after system resume and after hardware restarts
that are done when changing certain settings.
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index f4be5c7..8f985a8 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
spin_unlock_irq(&hw->hw_lock);
napi_enable(&skge->napi);
+
+ skge_set_multicast(dev);
+
return 0;
free_rx_ring:
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-29 6:48 ` Florian Zumbiehl
@ 2011-12-29 7:56 ` David Miller
2011-12-29 16:18 ` Stephen Hemminger
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2011-12-29 7:56 UTC (permalink / raw)
To: florz; +Cc: shemminger, netdev
From: Florian Zumbiehl <florz@florz.de>
Date: Thu, 29 Dec 2011 07:48:50 +0100
> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c
This file no longer exists in the current source tree.
All of the ethernet drivers have been moved to various directories
under drivers/net/ethernet
Please do not generate patches against older source trees.
And when I ask you to post a patch anew, please make it clean. In
this case you replied to my email, added some unrelated commentary,
and then included the commit log message and the patch.
This is not the correct way to do things. Post a fresh email, not a
reply, with a clean Subject line and the email body contents only
contain the commit log message and the subsequent patch.
If you don't do things the correct way, then the person applying your
patch has to do a lot of work editing things. If you do it the right
way, adding your patch is very easy.
See:
http://linux.yyz.us/patch-format.html
for more details
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] skge: restore multicast rx filter on resume
2011-12-29 7:56 ` David Miller
@ 2011-12-29 16:18 ` Stephen Hemminger
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Hemminger @ 2011-12-29 16:18 UTC (permalink / raw)
To: David Miller; +Cc: florz, netdev
On Thu, 29 Dec 2011 02:56:11 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Florian Zumbiehl <florz@florz.de>
> Date: Thu, 29 Dec 2011 07:48:50 +0100
>
> > --- a/drivers/net/skge.c
> > +++ b/drivers/net/skge.c
>
> This file no longer exists in the current source tree.
Florian the driver has moved to:
drivers/net/ethernet/marvell/skge.c
in latest kernel release.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-12-29 16:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-25 8:18 [PATCH] skge: restore multicast rx filter on resume Florian Zumbiehl
2011-12-26 20:17 ` David Miller
2011-12-27 17:56 ` Stephen Hemminger
2011-12-28 7:41 ` Florian Zumbiehl
2011-12-28 17:27 ` Stephen Hemminger
2011-12-28 18:09 ` David Miller
2011-12-29 6:48 ` Florian Zumbiehl
2011-12-29 7:56 ` David Miller
2011-12-29 16:18 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).