netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: florz@florz.de
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] skge: restore multicast rx filter on resume
Date: Thu, 29 Dec 2011 02:56:11 -0500 (EST)	[thread overview]
Message-ID: <20111229.025611.2043166821951238153.davem@davemloft.net> (raw)
In-Reply-To: <20111229064849.GB8041@florz.florz.dyndns.org>

From: Florian Zumbiehl <florz@florz.de>
Date: Thu, 29 Dec 2011 07:48:50 +0100

> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c

This file no longer exists in the current source tree.

All of the ethernet drivers have been moved to various directories
under drivers/net/ethernet

Please do not generate patches against older source trees.

And when I ask you to post a patch anew, please make it clean.  In
this case you replied to my email, added some unrelated commentary,
and then included the commit log message and the patch.

This is not the correct way to do things.  Post a fresh email, not a
reply, with a clean Subject line and the email body contents only
contain the commit log message and the subsequent patch.

If you don't do things the correct way, then the person applying your
patch has to do a lot of work editing things.  If you do it the right
way, adding your patch is very easy.

See:

	http://linux.yyz.us/patch-format.html

for more details

  reply	other threads:[~2011-12-29  7:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-25  8:18 [PATCH] skge: restore multicast rx filter on resume Florian Zumbiehl
2011-12-26 20:17 ` David Miller
2011-12-27 17:56   ` Stephen Hemminger
2011-12-28  7:41     ` Florian Zumbiehl
2011-12-28 17:27       ` Stephen Hemminger
2011-12-28 18:09         ` David Miller
2011-12-29  6:48           ` Florian Zumbiehl
2011-12-29  7:56             ` David Miller [this message]
2011-12-29 16:18               ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111229.025611.2043166821951238153.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=florz@florz.de \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).