From: David Miller <davem@davemloft.net>
To: yevgenyp@mellanox.co.il
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] mlx4_core: limiting VF port options
Date: Thu, 29 Dec 2011 15:09:59 -0500 (EST) [thread overview]
Message-ID: <20111229.150959.49185424410920094.davem@davemloft.net> (raw)
In-Reply-To: <4EFCA68F.9060904@mellanox.co.il>
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Thu, 29 Dec 2011 19:42:39 +0200
>
> At the moment VFs can only operate in Eth mode.
> In addition we don't want the VF to attempt link sensing,
> so we block this option as well.
>
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Applied, but:
> +#define MLX4_VF_PORT_ETH_ONLY_MASK 0xE6
Why don't you just clearly define what all the port type bits mean
instead of only defining some arbitrary combination of them?
What if people want to experiment with other bit mask settings? They
can't do that if you don't document the layout fully and properly.
prev parent reply other threads:[~2011-12-29 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 17:42 [PATCH net-next 2/2] mlx4_core: limiting VF port options Yevgeny Petrilin
2011-12-29 20:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111229.150959.49185424410920094.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).