From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: rusty@rustcorp.com.au, netdev@vger.kernel.org
Subject: Re: [PATCH] virtio_net: set/cancel work on ndo_open/ndo_stop
Date: Thu, 29 Dec 2011 16:44:52 -0500 (EST) [thread overview]
Message-ID: <20111229.164452.1646856455053448176.davem@davemloft.net> (raw)
In-Reply-To: <20111229203302.GA5051@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 29 Dec 2011 22:33:02 +0200
> On Thu, Dec 29, 2011 at 01:53:52PM +1030, Rusty Russell wrote:
>> Michael S. Tsirkin noticed that we could run the refill work after
>> ndo_close, which can re-enable napi - we don't disable it until
>> virtnet_remove. This is clearly wrong, so move the workqueue control
>> to ndo_open and ndo_stop (aka. virtnet_open and virtnet_close).
>>
>> One subtle point: virtnet_probe() could simply fail if it couldn't
>> allocate a receive buffer, but that's less polite in virtnet_open() so
>> we schedule a refill as we do in the normal receive path if we run out
>> of memory.
>>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied.
prev parent reply other threads:[~2011-12-29 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87hb0kgiwn.fsf@rustcorp.com.au>
2011-12-29 10:42 ` [PATCH] virtio_net: set/cancel work on ndo_open/ndo_stop Rusty Russell
2011-12-29 19:38 ` David Miller
2011-12-29 20:31 ` Michael S. Tsirkin
2011-12-29 21:44 ` David Miller
2012-04-04 9:32 ` question about napi_disable (was Re: [PATCH] virtio_net: set/cancel work on ndo_open/ndo_stop) Michael S. Tsirkin
2012-04-04 9:47 ` Michael S. Tsirkin
2012-04-05 6:32 ` Jason Wang
2011-12-29 20:33 ` [PATCH] virtio_net: set/cancel work on ndo_open/ndo_stop Michael S. Tsirkin
2011-12-29 21:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111229.164452.1646856455053448176.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).