From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] fix for nfacct infrastructure in net-next
Date: Sun, 01 Jan 2012 18:02:29 -0500 (EST) [thread overview]
Message-ID: <20120101.180229.1338519415596129407.davem@davemloft.net> (raw)
In-Reply-To: <20120101162358.GA21795@1984>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Sun, 1 Jan 2012 17:23:58 +0100
> On Sun, Jan 01, 2012 at 05:22:24PM +0100, pablo@netfilter.org wrote:
>> From: Pablo Neira Ayuso <pablo@netfilter.org>
>>
>> Hi Dave,
>>
>> Please, pull the following fix for the nfacct infrastructure already
>> in your net-next tree.
>>
>> You can pull it from:
>>
>> git://1984.lsi.us.es/net-net nf-next
> ^^^^^^^
> I meant to say net-next, of course.
I'm not pulling this.
If I pull from your "corrected" URL, "git://1984.lsi.us.es/net-next nf-next"
it starts to download 17937 objects. Which means it's going to bring in all
of your -next work as well as my net-next tree upon which it is based, not
just this one bug fix.
These mistakes should never happen in the first place.
If you actually use "git request-pull" to generate the pull request
email body, you can NEVER get the URL wrong, GIT enforces it to be
correct and it enforces that the changes in your local tree are
present at the remote URL as well.
You can't make these kinds of errors and oversights when you want to
ask me to pull in bug fixes at the very last minute when Linus is
about to make a final release.
Just toss these fixes, if they are so important submit them to Greg KH
and the -stable branch after 3.2.0-final goes out.
next prev parent reply other threads:[~2012-01-01 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-01 16:22 [PATCH] fix for nfacct infrastructure in net-next pablo
2012-01-01 16:22 ` [PATCH] netfilter: nfnetlink_acct: fix nfnl_acct_get operation pablo
2012-01-01 16:23 ` [PATCH] fix for nfacct infrastructure in net-next Pablo Neira Ayuso
2012-01-01 23:02 ` David Miller [this message]
2012-01-02 1:04 ` Pablo Neira Ayuso
2012-01-02 4:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120101.180229.1338519415596129407.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).