From: David Miller <davem@davemloft.net>
To: florian@openwrt.org
Cc: netdev@vger.kernel.org, vova.kolpakov@gmail.com
Subject: Re: [PATCH] r6040: use an unique MDIO bus name
Date: Mon, 02 Jan 2012 15:49:30 -0500 (EST) [thread overview]
Message-ID: <20120102.154930.1761330488764990513.davem@davemloft.net> (raw)
In-Reply-To: <1325497800-21450-1-git-send-email-florian@openwrt.org>
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 2 Jan 2012 10:50:00 +0100
> + snprintf(lp->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x",
> + dev_name(&pdev->dev), card_idx);
Please don't be so sloppy with the formatting like this,
make the arguments on the second line get indented exactly
to the first column after the openning parenthesis on the
first line.
If you can't be bothered to get this right by hand, use
something like emacs's C-mode to do it for you when you hit
TAB.
next prev parent reply other threads:[~2012-01-02 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 9:50 [PATCH] r6040: use an unique MDIO bus name Florian Fainelli
2012-01-02 20:49 ` David Miller [this message]
2012-01-04 18:50 ` [PATCH v2] " Florian Fainelli
2012-01-04 20:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102.154930.1761330488764990513.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=vova.kolpakov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).