From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 4/4] microblaze: Remove NO_IRQ from architecture Date: Mon, 2 Jan 2012 01:22:14 -0700 Message-ID: <20120102082214.GF18381@ponder.secretlab.ca> References: <1324477932-19262-1-git-send-email-monstr@monstr.eu> <1324477932-19262-2-git-send-email-monstr@monstr.eu> <1324477932-19262-3-git-send-email-monstr@monstr.eu> <1324477932-19262-4-git-send-email-monstr@monstr.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Ryan Mallon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Simek Return-path: Content-Disposition: inline In-Reply-To: <1324477932-19262-4-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: netdev.vger.kernel.org On Wed, Dec 21, 2011 at 03:32:12PM +0100, Michal Simek wrote: > NO_IRQ shouldn't be used by any driver. All Microblaze > drivers are fixed that's why NO_IRQ can be removed. > > Signed-off-by: Michal Simek > CC: Grant Likely > CC: Benjamin Herrenschmidt > CC: Ryan Mallon Acked-by: Grant Likely > --- > arch/microblaze/include/asm/irq.h | 2 -- > arch/microblaze/pci/pci-common.c | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/microblaze/include/asm/irq.h b/arch/microblaze/include/asm/irq.h > index b116a82..a175132 100644 > --- a/arch/microblaze/include/asm/irq.h > +++ b/arch/microblaze/include/asm/irq.h > @@ -27,8 +27,6 @@ typedef unsigned long irq_hw_number_t; > > extern unsigned int nr_irq; > > -#define NO_IRQ 0 > - > struct pt_regs; > extern void do_IRQ(struct pt_regs *regs); > > diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c > index db841c7..0d71b2e 100644 > --- a/arch/microblaze/pci/pci-common.c > +++ b/arch/microblaze/pci/pci-common.c > @@ -242,7 +242,7 @@ int pci_read_irq_line(struct pci_dev *pci_dev) > line, pin); > > virq = irq_create_mapping(NULL, line); > - if (virq != NO_IRQ) > + if (virq) > irq_set_irq_type(virq, IRQ_TYPE_LEVEL_LOW); > } else { > pr_debug(" Got one, spec %d cells (0x%08x 0x%08x...) on %s\n", > @@ -253,7 +253,7 @@ int pci_read_irq_line(struct pci_dev *pci_dev) > virq = irq_create_of_mapping(oirq.controller, oirq.specifier, > oirq.size); > } > - if (virq == NO_IRQ) { > + if (!virq) { > pr_debug(" Failed to map !\n"); > return -1; > } > -- > 1.7.5.4 >