From: David Miller <davem@davemloft.net>
To: martinez.javier@gmail.com
Cc: steve.glendinning@smsc.com, ben@decadent.org.uk,
eballetbo@iseebcn.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net/smsc911x: Check if PHY is in operational mode before software reset
Date: Tue, 03 Jan 2012 13:46:47 -0500 (EST) [thread overview]
Message-ID: <20120103.134647.1029494174636172958.davem@davemloft.net> (raw)
In-Reply-To: <1325524131-14585-2-git-send-email-martinez.javier@gmail.com>
From: Javier Martinez Canillas <martinez.javier@gmail.com>
Date: Mon, 2 Jan 2012 18:08:51 +0100
> + /* If energy is detected the PHY is already awake so is not necessary
> + * to disable the energy detect power-down mode. */
...
> + /* LAN9210/LAN9211/LAN9220/LAN9221 chips have an internal PHY that
> + * are initialized in a Energy Detect Power-Down mode that prevents
> + * the MAC chip to be software reseted. So we have to wakeup the PHY
> + * before */
Format these comments correctly:
/* Like this.
* See?
*/
/* Not like this.
* Ok? */
next prev parent reply other threads:[~2012-01-03 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 17:08 [PATCH 1/2] net: phy: smsc: Move SMSC PHY constants to <linux/smscphy.h> Javier Martinez Canillas
2012-01-02 17:08 ` [PATCH 2/2] net/smsc911x: Check if PHY is in operational mode before software reset Javier Martinez Canillas
2012-01-03 18:46 ` David Miller [this message]
2012-01-03 23:30 ` Javier Martinez Canillas
2012-01-04 1:18 ` David Miller
2012-01-03 18:45 ` [PATCH 1/2] net: phy: smsc: Move SMSC PHY constants to <linux/smscphy.h> David Miller
2012-01-03 23:29 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103.134647.1029494174636172958.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=eballetbo@iseebcn.com \
--cc=martinez.javier@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).