From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: fabio.estevam@freescale.com, netdev@vger.kernel.org,
w.sang@pengutronix.de, u.kleine-koenig@pengutronix.de,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: fsl: fec: fix build for mx23-only kernel
Date: Tue, 03 Jan 2012 13:48:51 -0500 (EST) [thread overview]
Message-ID: <20120103.134851.1069804762867901608.davem@davemloft.net> (raw)
In-Reply-To: <CAOMZO5BmKJP-3y_FxczuGwGfBR_3e2J9z3+gqzs-JDxOtR_PdQ@mail.gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 3 Jan 2012 13:37:47 -0200
> On Tue, Jan 3, 2012 at 11:46 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
>> If one only selects mx23-based boards, compile fails:
>>
>> drivers/net/ethernet/freescale/fec.c:410:2: error: 'FEC_HASH_TABLE_HIGH' undeclared (first use in this function)
>> drivers/net/ethernet/freescale/fec.c:411:2: error: 'FEC_HASH_TABLE_LOW' undeclared (first use in this function)
>>
>> This is because fec.h uses CONFIG_SOC_IMX28 to determine the register
>> layout of the core which makes sense since the MX23 does not have a fec.
>> However, Kconfig uses the broader ARCH_MXS symbol and this way even
>> makes the fec-driver default for MX23. Adapt Kconfig to use the more
>> precise SOC_IMX28 as well.
>>
>> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>> Cc: David S. Miller <davem@davemloft.net>
>
> Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thanks.
prev parent reply other threads:[~2012-01-03 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 13:46 [PATCH] net: fsl: fec: fix build for mx23-only kernel Wolfram Sang
2012-01-03 15:37 ` Fabio Estevam
2012-01-03 18:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103.134851.1069804762867901608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).