From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net_sched: sfq: fix mem alloc error recovery
Date: Wed, 04 Jan 2012 14:13:01 -0500 (EST) [thread overview]
Message-ID: <20120104.141301.1584452659395659449.davem@davemloft.net> (raw)
In-Reply-To: <1325694144.2428.30.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 04 Jan 2012 17:22:24 +0100
> Since commit 817fb15dfd98 (net_sched: sfq: allow divisor to be a
> parameter), we can leave perturbation timer armed if a memory allocation
> error aborts sfq_init().
>
> Memory containing active struct timer_list is freed and kernel can
> crash.
>
> Call sfq_destroy() from sfq_init() to properly dismantle qdisc.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2012-01-04 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 16:22 [PATCH net-next 1/2] net_sched: sfq: fix mem alloc error recovery Eric Dumazet
2012-01-04 19:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104.141301.1584452659395659449.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).