From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] ipv6: Check RA for sllao when configuring optimistic ipv6 address (v2)
Date: Wed, 04 Jan 2012 15:53:35 -0500 (EST) [thread overview]
Message-ID: <20120104.155335.352434092951444020.davem@davemloft.net> (raw)
In-Reply-To: <1325710155-30289-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 4 Jan 2012 15:49:15 -0500
> Recently Dave noticed that a test we did in ipv6_add_addr to see if we next hop
> route for the interface we're adding an addres to was wrong (see commit
> 7ffbcecbeed91e5874e9a1cfc4c0cbb07dac3069). for one, it never triggers, and two,
> it was completely wrong to begin with. This test was meant to cover this
> section of RFC 4429:
>
> 3.3 Modifications to RFC 2462 Stateless Address Autoconfiguration
>
> * (modifies section 5.5) A host MAY choose to configure a new address
> as an Optimistic Address. A host that does not know the SLLAO
> of its router SHOULD NOT configure a new address as Optimistic.
> A router SHOULD NOT configure an Optimistic Address.
>
> This patch should bring us into proper compliance with the above clause. Since
> we only add a SLAAC address after we've received a RA which may or may not
> contain a source link layer address option, we can pass a pointer to that option
> to addrconf_prefix_rcv (which may be null if the option is not present), and
> only set the optimistic flag if the option was found in the RA.
>
> Change notes:
> (v2) modified the new parameter to addrconf_prefix_rcv to be a bool rather than
> a pointer to make its use more clear as per request from davem.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks Neil.
prev parent reply other threads:[~2012-01-04 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 16:47 [PATCH] ipv6: Check RA for sllao when configuring optimistic ipv6 address Neil Horman
2012-01-04 19:43 ` David Miller
2012-01-04 19:52 ` Neil Horman
2012-01-04 20:49 ` [PATCH] ipv6: Check RA for sllao when configuring optimistic ipv6 address (v2) Neil Horman
2012-01-04 20:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104.155335.352434092951444020.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).