From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC PATCH v1 1/2] virtio_net: Pass gfp flags when allocating rx buffers. Date: Thu, 05 Jan 2012 13:21:04 -0500 (EST) Message-ID: <20120105.132104.1867723912140416026.davem@davemloft.net> References: <20120104225223.18184.1537.stgit@mike2.sea.corp.google.com> <20120104225231.18184.96390.stgit@mike2.sea.corp.google.com> <871urfc8md.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, mst@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mikew@google.com To: rusty@rustcorp.com.au Return-path: In-Reply-To: <871urfc8md.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Rusty Russell Date: Thu, 05 Jan 2012 10:40:02 +1030 > On Wed, 04 Jan 2012 14:52:32 -0800, Mike Waychison wrote: >> Currently, the refill path for RX buffers will always allocate the >> buffers as GFP_ATOMIC, even if we are in process context. This will >> fail to apply memory pressure as the worker thread will not contribute >> to the freeing of memory. >> >> Fix this by changing add_recvbuf_small to use the gfp variant allocator, >> __netdev_alloc_skb_ip_align(). >> >> Signed-off-by: Mike Waychison > > OK, this is a no-brainer. Thanks! Dave, can you pick this up? > > Acked-by: Rusty Russell Applied.