From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: rmody@brocade.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] bna: fix sparse warnings/errors
Date: Thu, 05 Jan 2012 13:23:51 -0500 (EST) [thread overview]
Message-ID: <20120105.132351.1997814540766162705.davem@davemloft.net> (raw)
In-Reply-To: <20120104230239.111580138@vyatta.com>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 04 Jan 2012 15:02:24 -0800
> This fixes a several sparse warnings.
> * the __iomem tag was being used incorrectly (needs to be a prefix)
> * several variables should have been static since local to one file
> * the firmware was not being forwared declared
> and was const one place and not the other
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
prev parent reply other threads:[~2012-01-05 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120104230222.355802239@vyatta.com>
2012-01-04 23:02 ` [PATCH 1/2] bna: make ethtool_ops and strings const Stephen Hemminger
2012-01-05 18:23 ` David Miller
2012-01-05 18:28 ` Rasesh Mody
2012-01-04 23:02 ` [PATCH 2/2] bna: fix sparse warnings/errors Stephen Hemminger
2012-01-05 18:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105.132351.1997814540766162705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).