From: David Miller <davem@davemloft.net>
To: manfred.rudigier@omicron.at
Cc: netdev@vger.kernel.org, afleming@freescale.com, avorontsov@mvista.com
Subject: Re: [PATCH] gianfar: Fix invalid TX frames returned on error queue when time stamping.
Date: Thu, 05 Jan 2012 13:26:37 -0500 (EST) [thread overview]
Message-ID: <20120105.132637.2130515220408371607.davem@davemloft.net> (raw)
In-Reply-To: <1325775021-23049-1-git-send-email-manfred.rudigier@omicron.at>
From: Manfred Rudigier <manfred.rudigier@omicron.at>
Date: Thu, 5 Jan 2012 15:50:21 +0100
> +
> + /* Keep sock if we must return a time stamp on the err queue */
> + skb_new->sk = skb->sk;
When I see something like this without any kind of reference counting or
similar, I am gravely concerned.
next prev parent reply other threads:[~2012-01-05 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 14:50 [PATCH] gianfar: Fix invalid TX frames returned on error queue when time stamping Manfred Rudigier
2012-01-05 18:26 ` David Miller [this message]
2012-01-09 7:16 ` Manfred Rudigier
2012-01-09 7:43 ` Eric Dumazet
2012-01-09 9:36 ` Manfred Rudigier
2012-01-09 9:58 ` Eric Dumazet
2012-01-09 10:43 ` Manfred Rudigier
2012-01-09 12:41 ` Richard Cochran
2012-01-09 12:50 ` Richard Cochran
2012-01-09 12:49 ` Richard Cochran
2012-01-09 14:45 ` Manfred Rudigier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105.132637.2130515220408371607.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=avorontsov@mvista.com \
--cc=manfred.rudigier@omicron.at \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).