From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: hagen@jauu.net, netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: Bug in netem reordering
Date: Thu, 05 Jan 2012 13:28:44 -0500 (EST) [thread overview]
Message-ID: <20120105.132844.667708412405670292.davem@davemloft.net> (raw)
In-Reply-To: <1325741656.2634.20.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 05 Jan 2012 06:34:16 +0100
> Le jeudi 05 janvier 2012 à 04:35 +0100, Hagen Paul Pfeifer a écrit :
>> Not now, but it looks you are correct. q->qdisc is NULL until another
>> additional qdisc is attached (beside tfifo). See 50612537e9ab2969312.
>> The following patch should work.
>>
>> From: Hagen Paul Pfeifer <hagen@jauu.net>
>>
>> netem: catch NULL pointer by updating the real qdisc statistic
>>
>> Reported-by: Vijay Subramanian <subramanian.vijay@gmail.com>
>> Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
>> ---
>
> Thanks for this fix !
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2012-01-05 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 0:44 Bug in netem reordering Vijay Subramanian
2012-01-05 3:35 ` Hagen Paul Pfeifer
2012-01-05 5:34 ` Eric Dumazet
2012-01-05 18:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105.132844.667708412405670292.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).