From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2 net-next] cnic: Improve error recovery on bnx2x devices
Date: Thu, 05 Jan 2012 14:08:35 -0500 (EST) [thread overview]
Message-ID: <20120105.140835.846952184860620132.davem@davemloft.net> (raw)
In-Reply-To: <1325715148-1371-2-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 4 Jan 2012 14:12:28 -0800
> When a bnx2x device encounters parity errors, it will not respond to all
> SPQ messages. As a result, the shutdown sequence before reset can take
> a long time as the ulp drivers (bnx2i/bnx2fc) have to wait for timeout
> of all such messages.
>
> To improve this scenario, when bnx2x returns error on the SPQ, we'll send
> an immediate response to the ulp drivers to avoid such lengthy timeouts.
>
> Adjust the return code of relevant functions to return error only if
> the message cannot be sent on the SPQ so that we'll generate an error
> completion to the ulp drivers.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
next prev parent reply other threads:[~2012-01-05 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 22:12 [PATCH 1/2 net-next] cnic: Re-init dev->stats_addr after chip reset Michael Chan
2012-01-04 22:12 ` [PATCH 2/2 net-next] cnic: Improve error recovery on bnx2x devices Michael Chan
2012-01-05 19:08 ` David Miller [this message]
2012-01-05 19:08 ` [PATCH 1/2 net-next] cnic: Re-init dev->stats_addr after chip reset David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105.140835.846952184860620132.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).