From: David Miller <davem@davemloft.net>
To: ian.campbell@citrix.com
Cc: devel@driverdev.osuosl.org, rds-devel@oss.oracle.com,
pekkas@netcore.fi, eric.dumazet@gmail.com,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, gregkh@suse.de,
Trond.Myklebust@netapp.com, jmorris@namei.org,
cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com,
kuznet@ms2.inr.ac.ru, ceph-devel@vger.kernel.org,
linux-nfs@vger.kernel.org, kaber@trash.net,
drbd-user@lists.linbit.com
Subject: Re: [PATCH 5/6] net: add paged frag destructor support to kernel_sendpage.
Date: Thu, 05 Jan 2012 14:15:22 -0500 (EST) [thread overview]
Message-ID: <20120105.141522.1303730212186060591.davem@davemloft.net> (raw)
In-Reply-To: <1325783624-14601-5-git-send-email-ian.campbell@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Thu, 5 Jan 2012 17:13:43 +0000
> -static ssize_t do_tcp_sendpages(struct sock *sk, struct page **pages, int poffset,
> +static ssize_t do_tcp_sendpages(struct sock *sk,
> + struct page **pages,
> + struct skb_frag_destructor **destructors,
> + int poffset,
> size_t psize, int flags)
> {
> struct tcp_sock *tp = tcp_sk(sk);
An array of destructors is madness, and the one call site that specifies this
passes an address of a single entry.
This also would never even have to occur if you put the destructor inside of
struct page instead.
Finally, except for the skb_shared_info() layout optimization in patch #1 which
I alreayd applied, this stuff is not baked enough for the 3.3 merge window.
next prev parent reply other threads:[~2012-01-05 19:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 17:09 [PATCH 0/6 v2] skb paged fragment destructors Ian Campbell
2012-01-05 17:13 ` [PATCH 1/6] net: pack skb_shared_info more efficiently Ian Campbell
2012-01-05 18:30 ` Eric Dumazet
2012-01-05 19:09 ` David Miller
2012-01-05 17:13 ` [PATCH 2/6] net: pad skb data and shinfo as a whole rather than individually Ian Campbell
2012-01-05 17:46 ` Eric Dumazet
2012-01-05 19:13 ` David Miller
2012-01-05 20:00 ` Ian Campbell
2012-01-07 18:18 ` David Miller
2012-01-05 19:19 ` Ian Campbell
2012-01-05 20:22 ` Eric Dumazet
2012-01-06 11:20 ` Ian Campbell
2012-01-06 12:33 ` Eric Dumazet
2012-01-06 13:20 ` Ian Campbell
2012-01-06 13:37 ` Eric Dumazet
2012-01-06 13:49 ` Ian Campbell
2012-01-06 13:29 ` Ian Campbell
2012-01-05 17:13 ` [PATCH 3/6] net: add support for per-paged-fragment destructors Ian Campbell
2012-01-06 1:15 ` Michał Mirosław
2012-01-06 8:50 ` Ian Campbell
2012-01-05 17:13 ` [PATCH 4/6] net: only allow paged fragments with the same destructor to be coalesced Ian Campbell
2012-01-05 17:13 ` [PATCH 5/6] net: add paged frag destructor support to kernel_sendpage Ian Campbell
2012-01-05 19:15 ` David Miller [this message]
2012-01-05 20:04 ` Ian Campbell
[not found] ` <1325783399.25206.413.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-01-05 17:13 ` [PATCH 6/6] sunrpc: use SKB fragment destructors to delay completion until page is released by network stack Ian Campbell
2012-01-05 17:27 ` [PATCH 0/6 v2] skb paged fragment destructors David Laight
2012-01-05 17:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105.141522.1303730212186060591.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Trond.Myklebust@netapp.com \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=drbd-user@lists.linbit.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=ian.campbell@citrix.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=pekkas@netcore.fi \
--cc=rds-devel@oss.oracle.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).