From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC] pktgen: set correct max and min in pktgen_setup_inject()
Date: Fri, 6 Jan 2012 09:29:12 -0800 [thread overview]
Message-ID: <20120106092912.000015cd@unknown> (raw)
In-Reply-To: <20120106131346.GA2491@elgon.mountain>
On Fri, 6 Jan 2012 05:13:47 -0800
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> In 882716604ec "pktgen: fix multiple queue warning" we added special
> logic to handle the case where ntxq is zero. It's not clear to me that
> ntxq can actually be zero. But if it were then we would set
> ->queue_map_min and ->queue_map_max to USHRT_MAX when probably we want
> to set them to zero?
seems fine to me, esp since -1 seems like a bad value there.
next prev parent reply other threads:[~2012-01-06 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 13:13 [RFC] pktgen: set correct max and min in pktgen_setup_inject() Dan Carpenter
2012-01-06 17:29 ` Jesse Brandeburg [this message]
2012-01-07 20:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106092912.000015cd@unknown \
--to=jesse.brandeburg@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).