From: David Miller <davem@davemloft.net>
To: jussi.kivilinna@mbnet.fi
Cc: netdev@vger.kernel.org, grundler@chromium.org, allan@asix.com.tw
Subject: Re: [PATCH 2/2] asix: fix setting custom MAC address on Asix 88178 devices
Date: Tue, 10 Jan 2012 15:00:51 -0800 (PST) [thread overview]
Message-ID: <20120110.150051.1786115333097978498.davem@davemloft.net> (raw)
In-Reply-To: <20120110164023.24658.76719.stgit@localhost6.localdomain6>
From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Date: Tue, 10 Jan 2012 18:40:23 +0200
> (Note: only compile tested, I don't have 88178 device to confirm that this
> patch works. Please, test.)
>
> ---
>
> In kernel v3.2 initialization sequence for Asix 88178 devices was changed so
> that hardware is reseted on every time interface is brought up (ifconfig up),
> instead just at USB probe time. This causes problem with setting custom MAC
> address to device as ax88178_reset causes reload of MAC address from EEPROM.
>
> This patch fixes the issue by rewriting MAC address at end of ax88178_reset.
>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> Cc: Grant Grundler <grundler@chromium.org>
> Cc: Allan Chou <allan@asix.com.tw>
> Cc: stable <stable@vger.kernel.org>
> ---
Please do not format your commit messages like this, everything after
that first "---" will be stripped away. So in this case if I applied
this email into GIT as-is we'd lose the actual commit message and
only have your "(Note: " thing.
I fixed this up and applied it with Grant's ACK.
next prev parent reply other threads:[~2012-01-10 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:40 [PATCH 1/2] asix: fix setting custom MAC address on Asix 88772 devices Jussi Kivilinna
2012-01-10 16:40 ` [PATCH 2/2] asix: fix setting custom MAC address on Asix 88178 devices Jussi Kivilinna
2012-01-10 18:43 ` Grant Grundler
2012-01-10 23:00 ` David Miller [this message]
2012-01-11 14:22 ` Jussi Kivilinna
2012-01-10 23:00 ` [PATCH 1/2] asix: fix setting custom MAC address on Asix 88772 devices David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110.150051.1786115333097978498.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan@asix.com.tw \
--cc=grundler@chromium.org \
--cc=jussi.kivilinna@mbnet.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).