From: Richard Cochran <richardcochran@gmail.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net-next V3 1/2] igb: add PTP Hardware Clock code
Date: Tue, 10 Jan 2012 09:44:50 +0100 [thread overview]
Message-ID: <20120110084450.GA5356@cherladcori01> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB5801E86F@ORSMSX106.amr.corp.intel.com>
On Mon, Jan 09, 2012 at 05:42:20PM +0000, Keller, Jacob E wrote:
> Is there a reason for not using the timecounter structure from the
> kernel? It is a layer beneath the timecompare code which is meant to
> handle this condition. As far as I can tell this issue is solved in
> the timecounter code. If it is not, then that should be a bug in the
> timecounter cyclecounter code. I don't know if this issue occurs in
> the timecounter structure because it handles the ns conversion
> differently.
My only reason is that I am not sure that the timecounter code really
does what we need. It might well work. Consider, though, that the
82580 register does not overflow in the usual way. The upper 24 bits
are always zero.
What I wrote does the right thing, I think. However, duplicated
effort is always bad, so can you show me how to change it?
Thanks,
Richard
next prev parent reply other threads:[~2012-01-10 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 19:38 [PATCH net-next V3 0/2] igb: ptp hardware clock Richard Cochran
2012-01-07 19:38 ` [PATCH net-next V3 1/2] igb: add PTP Hardware Clock code Richard Cochran
2012-01-09 17:42 ` Keller, Jacob E
2012-01-10 8:44 ` Richard Cochran [this message]
2012-01-10 9:33 ` Richard Cochran
2012-01-11 17:14 ` Keller, Jacob E
2012-01-07 19:38 ` [PATCH net-next V3 2/2] igb: offer a PTP Hardware Clock instead of the timecompare method Richard Cochran
2012-01-08 1:02 ` [PATCH net-next V3 0/2] igb: ptp hardware clock Jeff Kirsher
2012-01-19 9:39 ` Richard Cochran
2012-01-19 9:56 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110084450.GA5356@cherladcori01 \
--to=richardcochran@gmail.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.ronciak@intel.com \
--cc=john.stultz@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).