From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
To: netdev@vger.kernel.org
Cc: Grant Grundler <grundler@chromium.org>,
Allan Chou <allan@asix.com.tw>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 2/2] asix: fix setting custom MAC address on Asix 88178 devices
Date: Tue, 10 Jan 2012 18:40:23 +0200 [thread overview]
Message-ID: <20120110164023.24658.76719.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20120110164017.24658.9965.stgit@localhost6.localdomain6>
(Note: only compile tested, I don't have 88178 device to confirm that this
patch works. Please, test.)
---
In kernel v3.2 initialization sequence for Asix 88178 devices was changed so
that hardware is reseted on every time interface is brought up (ifconfig up),
instead just at USB probe time. This causes problem with setting custom MAC
address to device as ax88178_reset causes reload of MAC address from EEPROM.
This patch fixes the issue by rewriting MAC address at end of ax88178_reset.
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: Grant Grundler <grundler@chromium.org>
Cc: Allan Chou <allan@asix.com.tw>
Cc: stable <stable@vger.kernel.org>
---
drivers/net/usb/asix.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index eb6b4c1..4736425 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -1324,6 +1324,13 @@ static int ax88178_reset(struct usbnet *dev)
if (ret < 0)
return ret;
+ /* Rewrite MAC address */
+ memcpy(data->mac_addr, dev->net->dev_addr, ETH_ALEN);
+ ret = asix_write_cmd(dev, AX_CMD_WRITE_NODE_ID, 0, 0, ETH_ALEN,
+ data->mac_addr);
+ if (ret < 0)
+ return ret;
+
ret = asix_write_rx_ctl(dev, AX_DEFAULT_RX_CTL);
if (ret < 0)
return ret;
next prev parent reply other threads:[~2012-01-10 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:40 [PATCH 1/2] asix: fix setting custom MAC address on Asix 88772 devices Jussi Kivilinna
2012-01-10 16:40 ` Jussi Kivilinna [this message]
2012-01-10 18:43 ` [PATCH 2/2] asix: fix setting custom MAC address on Asix 88178 devices Grant Grundler
2012-01-10 23:00 ` David Miller
2012-01-11 14:22 ` Jussi Kivilinna
2012-01-10 23:00 ` [PATCH 1/2] asix: fix setting custom MAC address on Asix 88772 devices David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110164023.24658.76719.stgit@localhost6.localdomain6 \
--to=jussi.kivilinna@mbnet.fi \
--cc=allan@asix.com.tw \
--cc=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).