* [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning
@ 2012-01-10 9:52 Manfred Rudigier
2012-01-11 19:03 ` Richard Cochran
0 siblings, 1 reply; 5+ messages in thread
From: Manfred Rudigier @ 2012-01-10 9:52 UTC (permalink / raw)
To: davem; +Cc: netdev, richardcochran, Manfred Rudigier
Similar problem as in 481a8199142c050b72bff8a1956a49fd0a75bbe0. This fix
replaces netif_rx() with netif_rx_ni() which has to be used from
process/softirq context.
Signed-off-by: Manfred Rudigier <manfred.rudigier@omicron.at>
---
drivers/net/phy/dp83640.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 9663e0b..ba3c591 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1159,7 +1159,7 @@ static void rx_timestamp_work(struct work_struct *work)
}
}
spin_unlock_irqrestore(&dp83640->rx_lock, flags);
- netif_rx(skb);
+ netif_rx_ni(skb);
}
/* Clear out expired time stamps. */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning
2012-01-10 9:52 [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning Manfred Rudigier
@ 2012-01-11 19:03 ` Richard Cochran
2012-01-12 11:56 ` Manfred Rudigier
0 siblings, 1 reply; 5+ messages in thread
From: Richard Cochran @ 2012-01-11 19:03 UTC (permalink / raw)
To: Manfred Rudigier; +Cc: davem, netdev
On Tue, Jan 10, 2012 at 10:52:15AM +0100, Manfred Rudigier wrote:
> Similar problem as in 481a8199142c050b72bff8a1956a49fd0a75bbe0. This fix
> replaces netif_rx() with netif_rx_ni() which has to be used from
> process/softirq context.
Thanks for spotting this. Can you post this once again with a Cc tag
for the stable branch, too?
Thanks,
Richard
>
> Signed-off-by: Manfred Rudigier <manfred.rudigier@omicron.at>
> ---
> drivers/net/phy/dp83640.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
> index 9663e0b..ba3c591 100644
> --- a/drivers/net/phy/dp83640.c
> +++ b/drivers/net/phy/dp83640.c
> @@ -1159,7 +1159,7 @@ static void rx_timestamp_work(struct work_struct *work)
> }
> }
> spin_unlock_irqrestore(&dp83640->rx_lock, flags);
> - netif_rx(skb);
> + netif_rx_ni(skb);
> }
>
> /* Clear out expired time stamps. */
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning
2012-01-11 19:03 ` Richard Cochran
@ 2012-01-12 11:56 ` Manfred Rudigier
0 siblings, 0 replies; 5+ messages in thread
From: Manfred Rudigier @ 2012-01-12 11:56 UTC (permalink / raw)
To: Richard Cochran; +Cc: davem@davemloft.net, netdev@vger.kernel.org
From: Richard Cochran [mailto:richardcochran@gmail.com]
Sent: Wednesday, January 11, 2012 20:03
>> fix replaces netif_rx() with netif_rx_ni() which has to be used from
>> process/softirq context.
>
>Thanks for spotting this. Can you post this once again with a Cc tag for the
>stable branch, too?
>
>Thanks,
>Richard
Okay.
Manfred
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning
@ 2012-01-12 11:58 Manfred Rudigier
2012-01-12 19:51 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Manfred Rudigier @ 2012-01-12 11:58 UTC (permalink / raw)
To: davem; +Cc: netdev, stable, richardcochran, Manfred Rudigier
Similar problem as in 481a8199142c050b72bff8a1956a49fd0a75bbe0. This fix
replaces netif_rx() with netif_rx_ni() which has to be used from
process/softirq context.
Signed-off-by: Manfred Rudigier <manfred.rudigier@omicron.at>
---
drivers/net/phy/dp83640.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 9663e0b..ba3c591 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1159,7 +1159,7 @@ static void rx_timestamp_work(struct work_struct *work)
}
}
spin_unlock_irqrestore(&dp83640->rx_lock, flags);
- netif_rx(skb);
+ netif_rx_ni(skb);
}
/* Clear out expired time stamps. */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning
2012-01-12 11:58 Manfred Rudigier
@ 2012-01-12 19:51 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2012-01-12 19:51 UTC (permalink / raw)
To: Manfred Rudigier; +Cc: davem, netdev, stable, richardcochran
On Thu, Jan 12, 2012 at 12:58:05PM +0100, Manfred Rudigier wrote:
> Similar problem as in 481a8199142c050b72bff8a1956a49fd0a75bbe0. This fix
> replaces netif_rx() with netif_rx_ni() which has to be used from
> process/softirq context.
>
> Signed-off-by: Manfred Rudigier <manfred.rudigier@omicron.at>
> ---
> drivers/net/phy/dp83640.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-12 20:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-10 9:52 [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning Manfred Rudigier
2012-01-11 19:03 ` Richard Cochran
2012-01-12 11:56 ` Manfred Rudigier
-- strict thread matches above, loose matches on Subject: below --
2012-01-12 11:58 Manfred Rudigier
2012-01-12 19:51 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).