netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Gospodarek <gospo@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: maxim.uvarov@oracle.com, netdev@vger.kernel.org,
	fubar@us.ibm.com, andy@greyhouse.net, amwang@redhat.com
Subject: Re: [PATCHv2] bond_alb: don't disable softirq under bond_alb_xmit
Date: Wed, 11 Jan 2012 16:26:36 -0500	[thread overview]
Message-ID: <20120111212636.GE32485@quad.redhat.com> (raw)
In-Reply-To: <20120111.125246.979686086126749318.davem@davemloft.net>

On Wed, Jan 11, 2012 at 12:52:46PM -0800, David Miller wrote:
> From: Maxim Uvarov <maxim.uvarov@oracle.com>
> Date: Mon,  9 Jan 2012 14:01:37 -0800
> 
> > No need to lock soft irqs under bond_alb_xmit()
> > which already has softirq disabled.
> > 
> > Changes:
> > 1. add non-bh/bh version to tlb_clear_slave()
> > 
> > 2. represent BH and non BH hash table locks
> > _lock_rx_hashtbl_bh/_unlock_rx_hashtbl_bh
> > _lock_rx_hashtbl/_unlock_rx_hashtbl
> > _lock_tx_hashtbl_bh/_unlock_tx_hashtbl_bh
> > _lock_tx_hashtbl/_unlock_tx_hashtbl
> > 
> > Signed-off-by: Maxim Uvarov <maxim.uvarov@oracle.com>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
> 
> Applied, thanks.

Thanks, Dave.  I'm still testing, but everything looks good so far.  I
ran into an issue with my test system and it took longer to get going
than I expected.  I should be done later tonight and will post if I find
anything wrong.

It's probably too late, but you can feel free to add a

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>

if you want.

      reply	other threads:[~2012-01-11 21:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 22:01 [PATCHv2] bond_alb: don't disable softirq under bond_alb_xmit Maxim Uvarov
2012-01-09 22:20 ` Andy Gospodarek
2012-01-10  3:09   ` Maxim Uvarov
2012-01-10 17:52     ` Andy Gospodarek
2012-01-11 20:52 ` David Miller
2012-01-11 21:26   ` Andy Gospodarek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120111212636.GE32485@quad.redhat.com \
    --to=gospo@redhat.com \
    --cc=amwang@redhat.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=maxim.uvarov@oracle.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).