* [PATCH v2] ksz884x: fix mtu for VLAN
@ 2012-01-11 23:12 Doug Kehn
2012-01-13 4:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Doug Kehn @ 2012-01-11 23:12 UTC (permalink / raw)
To: netdev
The Ethernet header does not account for the addition of a VLAN header.
Full size Ethernet frames containing VLAN header are not processed
because the frame is larger than the resulting hw mtu.
Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
---
drivers/net/ethernet/micrel/ksz884x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 6ed09a8..e52cd31 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -746,7 +746,7 @@
#define MAC_ADDR_ORDER(i) (ETH_ALEN - 1 - (i))
#define MAX_ETHERNET_BODY_SIZE 1500
-#define ETHERNET_HEADER_SIZE 14
+#define ETHERNET_HEADER_SIZE (14 + VLAN_HLEN)
#define MAX_ETHERNET_PACKET_SIZE \
(MAX_ETHERNET_BODY_SIZE + ETHERNET_HEADER_SIZE)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ksz884x: fix mtu for VLAN
2012-01-11 23:12 [PATCH v2] ksz884x: fix mtu for VLAN Doug Kehn
@ 2012-01-13 4:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-01-13 4:06 UTC (permalink / raw)
To: rdkehn; +Cc: netdev
From: Doug Kehn <rdkehn@yahoo.com>
Date: Wed, 11 Jan 2012 17:12:43 -0600
> The Ethernet header does not account for the addition of a VLAN header.
> Full size Ethernet frames containing VLAN header are not processed
> because the frame is larger than the resulting hw mtu.
>
> Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-13 4:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 23:12 [PATCH v2] ksz884x: fix mtu for VLAN Doug Kehn
2012-01-13 4:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).