From: David Miller <davem@davemloft.net>
To: kay.sievers@vrfy.org
Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, shemminger@vyatta.com,
device@lanana.org
Subject: Re: [PATCH] vhost-net: add module alias (v2.1)
Date: Fri, 13 Jan 2012 10:12:45 -0800 (PST) [thread overview]
Message-ID: <20120113.101245.1898604125300586417.davem@davemloft.net> (raw)
In-Reply-To: <CAPXgP10uf-5wDxGOP8yhfUcn+18Ga+eZp-Psz_Pxe9PoJZagoA@mail.gmail.com>
From: Kay Sievers <kay.sievers@vrfy.org>
Date: Fri, 13 Jan 2012 05:19:05 +0100
> On Fri, Jan 13, 2012 at 05:07, David Miller <davem@davemloft.net> wrote:
>> From: Stephen Hemminger <shemminger@vyatta.com>
>> Date: Wed, 11 Jan 2012 21:30:38 -0800
>>
>>> Subject: vhost-net: add module alias (v2.1)
>>>
>>> By adding some module aliases, programs (or users) won't have to explicitly
>>> call modprobe. Vhost-net will always be available if built into the kernel.
>>> It does require assigning a permanent minor number for depmod to work.
>>>
>>> Also:
>>> - use C99 style initialization.
>>> - add missing entry in documentation for loop-control
>>>
>>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>> ACKs, NACKs? What is happening here?
>
> In general, static minors are acceptable and very useful to make
> on-demand loading of kernel modules working. They should be used only
> for single-instance devices though, which usually means: One single
> static device name associated with a module.
>
> That looks all fine here, and for what it's worth:
> Acked-By: Kay Sievers <kay.sievers@vrfy.org>
Ok, applied, thanks everyone.
next prev parent reply other threads:[~2012-01-13 18:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 4:54 [PATCH] vhost-net: add module alias Stephen Hemminger
2012-01-11 7:07 ` Michael Tokarev
2012-01-11 16:58 ` Stephen Hemminger
2012-01-11 17:02 ` Michael Tokarev
2012-01-11 17:03 ` Kay Sievers
2012-01-11 7:43 ` Amos Kong
2012-01-11 16:54 ` Stephen Hemminger
2012-01-11 18:15 ` Michael S. Tsirkin
2012-01-11 17:16 ` [PATCH] vhost-net: add module alias (v2) Stephen Hemminger
2012-01-11 18:09 ` Michael S. Tsirkin
2012-01-11 21:00 ` Ben Hutchings
2012-01-12 2:15 ` Zhi Yong Wu
2012-01-12 5:30 ` [PATCH] vhost-net: add module alias (v2.1) Stephen Hemminger
2012-01-13 4:07 ` David Miller
2012-01-13 4:19 ` Kay Sievers
2012-01-13 18:12 ` David Miller [this message]
2012-01-15 12:42 ` Michael S. Tsirkin
2012-01-16 12:26 ` Alan Cox
2012-01-16 15:52 ` Stephen Hemminger
2012-01-16 23:06 ` David Miller
2012-01-16 23:34 ` Alan Cox
2012-01-12 20:04 ` [PATCH] vhost-net: add module alias (v2) Thadeu Lima de Souza Cascardo
2012-01-16 12:28 ` [PATCH] vhost-net: add module alias Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113.101245.1898604125300586417.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=device@lanana.org \
--cc=kay.sievers@vrfy.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).