From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] vhost-net: add module alias (v2.1) Date: Fri, 13 Jan 2012 10:12:45 -0800 (PST) Message-ID: <20120113.101245.1898604125300586417.davem@davemloft.net> References: <20120111213038.39213819@nehalam.linuxnetplumber.net> <20120112.200701.1473475851890804136.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, shemminger@vyatta.com, device@lanana.org To: kay.sievers@vrfy.org Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Kay Sievers Date: Fri, 13 Jan 2012 05:19:05 +0100 > On Fri, Jan 13, 2012 at 05:07, David Miller wrote: >> From: Stephen Hemminger >> Date: Wed, 11 Jan 2012 21:30:38 -0800 >> >>> Subject: vhost-net: add module alias (v2.1) >>> >>> By adding some module aliases, programs (or users) won't have to explic= itly >>> call modprobe. Vhost-net will always be available if built into the ker= nel. >>> It does require assigning a permanent minor number for depmod to work. >>> >>> Also: >>> =A0 - use C99 style initialization. >>> =A0 - add missing entry in documentation for loop-control >>> >>> Signed-off-by: Stephen Hemminger >> >> ACKs, NACKs? =A0What is happening here? > = > In general, static minors are acceptable and very useful to make > on-demand loading of kernel modules working. They should be used only > for single-instance devices though, which usually means: One single > static device name associated with a module. > = > That looks all fine here, and for what it's worth: > Acked-By: Kay Sievers Ok, applied, thanks everyone.